Remove unused AbstractSchemaManager method parameters#6750
Merged
morozov merged 1 commit intodoctrine:5.0.xfrom Jan 29, 2025
Merged
Remove unused AbstractSchemaManager method parameters#6750morozov merged 1 commit intodoctrine:5.0.xfrom
morozov merged 1 commit intodoctrine:5.0.xfrom
Conversation
greg0ire
approved these changes
Jan 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cleanup is possible as a result of #6744.
The affected methods are all protected, and I haven't seen people maintaining their custom platforms or schema managers, so I think it's safe to just modify the signatures w/o documenting it or providing an upgrade path.