Skip to content

Merge 3.10.x up into 4.2.x#6758

Closed
morozov wants to merge 11 commits intodoctrine:4.2.xfrom
morozov:4.2.x
Closed

Merge 3.10.x up into 4.2.x#6758
morozov wants to merge 11 commits intodoctrine:4.2.xfrom
morozov:4.2.x

Conversation

@morozov
Copy link
Member

@morozov morozov commented Feb 2, 2025

No description provided.

derrabus and others added 11 commits January 6, 2025 17:56
* 3.9.x:
  PHPStan 2.1.1 (doctrine#6690)
  PHPUnit 9.6.22 (doctrine#6691)
  Bump doctrine/.github from 6.0.0 to 7.1.0 (doctrine#6649)
  Bump doctrine/.github from 5.3.0 to 6.0.0 (doctrine#6642)
* 3.9.x:
  bugfix: deallocate mysqli prepared statement (doctrine#6681)
|      Q       |   A
|------------- | -----------
| Type         | improvement
| Fixed issues | N/A

#### Summary

We'd like to flag the the doctrine/cache package as abandoned which
means it needs to disappear from the list of mandatory dependencies of
DBAL. In DBAL 3.9, the doctrine/cache classes are used for deprecated
code paths only.

Note: This change could break downstream projects if they rely on DBAL
installing the Cache package for them.
…ntifiers

Auto-quote introspected PostgreSQL identifiers
…e-comment-introspection

Fix introspection of table options in non-default schemas
@derrabus
Copy link
Member

derrabus commented Feb 2, 2025

Shouldn't 3.10 be merged into 4.3? 💎

@morozov
Copy link
Member Author

morozov commented Feb 2, 2025

Why is that? Do we not want the bug fixed to be available in 4.2.x? I may be missing something.

@derrabus
Copy link
Member

derrabus commented Feb 2, 2025

Bugfixes go to 3.9 which is merged into 4.2.

@derrabus
Copy link
Member

derrabus commented Feb 2, 2025

You're about to merge an unreleased feature release into a maintenance branch.

@morozov morozov closed this Feb 2, 2025
@morozov
Copy link
Member Author

morozov commented Feb 2, 2025

FWIW, I'm considering to not fix all the bugs that I've discovered while working on 5.0 back in 3.x. Some of them are edge-cases which existed for years but weren't reported by users. The process of backporting the fixes and then merging them back up takes time and produces no value. And I hope that we stop supporting 3.x sooner than later anyways.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants