Merged
Conversation
The table contained an error which broke the parsing of the table. Row content cannot be at the same line as the row span definition.
[DOCS] Fix binary type format documentation
…name Use function db2_field_name
1. This is consistent with using other views from SYSCAT 2. SYSCAT is considered more stable and externally facing, while SYSIBM is considered internal.
sys.tables represents only user-defined tables, so this way there is no need to filter them by type = 'U'.
1. Try to keep the query as static as possible to make them more readable and possible to analyze by IDEs. As an exception to this rule, consolidate exclusion of special tables in one place. 2. Use more specific fetch methods where possible. For example, where it eliminates the need to normalize fetched column names. 3. Bind all parameters instead of using string literals. 4. Order introspected rows by schema name and table name.
…ntifiers Auto-quote introspected PostgreSQL identifiers
…e-comment-introspection Fix introspection of table options in non-default schemas
…table-definition Deprecate `AbstractSchemaManager::_getPortableTableDefinition()`
Refactor building schema introspection queries
greg0ire
approved these changes
Feb 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.