Tests: Added drop and create schema helper methods#6786
Merged
morozov merged 1 commit intodoctrine:3.9.xfrom Feb 17, 2025
Merged
Tests: Added drop and create schema helper methods#6786morozov merged 1 commit intodoctrine:3.9.xfrom
morozov merged 1 commit intodoctrine:3.9.xfrom
Conversation
cristi-contiu
commented
Feb 16, 2025
| 'default schema' => ['some_table'], | ||
| 'unquoted schema' => ['test_drop_index_schema.some_table'], | ||
| 'quoted schema' => ['"test_drop_index_schema".some_table'], | ||
| 'unquoted schema' => ['other_schema.some_table'], |
Contributor
Author
There was a problem hiding this comment.
Intentionally changed the name so it conflicts with previous test
Member
|
Looks great! Please squash everything into one commit. |
cristi-contiu
force-pushed
the
helper-drop-create-schema
branch
from
4220878 to
665ff4b
Compare
Contributor
Author
|
@morozov Done. Let me know if I can assist in porting this and the other PRs into 4.2.x. |
morozov
approved these changes
Feb 17, 2025
Member
|
The merge up PR is #6792 if you want to take a look. |
Member
|
@cristi-contiu once #6793 is merged, do you want to give it a try and replace UPD: I did it myself: #6794 (sorry, was just going to check if there were any caveats and ended up writing all the code 🤪). |
Contributor
Author
|
@morozov They all look good, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Helper methods in tests for dropping and creating schemas for PostgreSQL and MS SQL Server. See #6773 (comment)