Only trim the leading slash from the DSN if a host is also available#6790
Merged
derrabus merged 2 commits intodoctrine:4.2.xfrom Apr 9, 2025
TimWolla:dsn-parser-quoted
Merged
Only trim the leading slash from the DSN if a host is also available#6790derrabus merged 2 commits intodoctrine:4.2.xfrom TimWolla:dsn-parser-quoted
derrabus merged 2 commits intodoctrine:4.2.xfrom
TimWolla:dsn-parser-quoted
Conversation
Previously the DsnParser unconditionally removed the first character from the path, without verifying that it is actually a slash and that it is dealing with a reasonably well-formed URI. This causes confusing behavior when a malformed URI that survives `parse_url()` is passed to `parse()`, since DsnParser would return the input as the `dbname`, but with the first character missing. This can lead to hard-to-debug situations when the DSN is coming from an environment variable, where quoting characters are accidentally included in the value itself, instead of being interpreted by the tool setting the env, since the `dbname` almost looks like the intended input (but still having the trailing quote). see #6789
`normalizeDatabaseUrlPath()` is only ever called if a `host` is available, which means that the path needs to start with a slash. Replace the `if()` by an `assert()` to satisfy Codecov.
derrabus
approved these changes
Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously the DsnParser unconditionally removed the first character from the path, without verifying that it is actually a slash and that it is dealing with a reasonably well-formed URI. This causes confusing behavior when a malformed URI that survives
parse_url()is passed toparse(), since DsnParser would return the input as thedbname, but with the first character missing.This can lead to hard-to-debug situations when the DSN is coming from an environment variable, where quoting characters are accidentally included in the value itself, instead of being interpreted by the tool setting the env, since the
dbnamealmost looks like the intended input (but still having the trailing quote).see #6789