Refactor SQL Server code for calling stored procedures

[morozov]

I want to unify the SQL Server platform code for calling stored procedures. This is a backport of the backward-compatible part of the changes that I'm planning for 5.0.x:

1. Instead of using string concatenation in every method that needs to execute a stored procedure, use SQLServerPlatform#getExecSQL().
2. Instead of manually prepending N to national string literals, use SQLServerPlatform#quoteNationalStringLiteral().

Eventually, it will allow to get rid of the methods with the signatures like this:

dbal/src/Platforms/SQLServerPlatform.php

Lines 675 to 693 in c17f856

	* @param string $name The name of the property to add.
	* @param string|null $value The value of the property to add.
	* @param string|null $level0Type The type of the object at level 0 the property belongs to.
	* @param string|null $level0Name The name of the object at level 0 the property belongs to.
	* @param string|null $level1Type The type of the object at level 1 the property belongs to.
	* @param string|null $level1Name The name of the object at level 1 the property belongs to.
	* @param string|null $level2Type The type of the object at level 2 the property belongs to.
	* @param string|null $level2Name The name of the object at level 2 the property belongs to.
	*/
	protected function getAddExtendedPropertySQL(
	string $name,
	?string $value = null,
	?string $level0Type = null,
	?string $level0Name = null,
	?string $level1Type = null,
	?string $level1Name = null,
	?string $level2Type = null,
	?string $level2Name = null,
	): string {

They are just boilerplate that mimics the signatures of the corresponding stored procedures. They don't enforce the contract that the arguments need to be passed in pairs and can generate syntactically invalid SQL. For instance, here, if $level2Type is not null but $level2Name is:

dbal/src/Platforms/SQLServerPlatform.php

Lines 699 to 702 in a030c1e

	($level2Type !== null || $level2Name !== null
	? ', N' . $this->quoteStringLiteral($level2Type ?? '') . ', ' . $level2Name
	: ''
	);

[greg0ire]

Refactor comment code in SQL Server platform

Sorry, what does this have to do with comments? Or did you mean to write "common"?

[morozov]

No, most of the affected methods (e.g. SQLServerPlatform#getAddExtendedPropertySQL) are used for managing table and column comments. Although, I guess, focusing on stored procedures in the subject would be more appropriate.