Rework code for working with extended properties#6798
Merged
morozov merged 2 commits intodoctrine:5.0.xfrom Feb 18, 2025
Merged
Rework code for working with extended properties#6798morozov merged 2 commits intodoctrine:5.0.xfrom
morozov merged 2 commits intodoctrine:5.0.xfrom
Conversation
greg0ire
approved these changes
Feb 18, 2025
SenseException
approved these changes
Feb 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the code that invokes the stored procedures that work with SQL Server extended properties. It removes
SQLServerPlatform#getAddExtendedPropertySQL()and other similar methods in favor of usingSQLServerPlatform#getExecSQL()and building the procedure parameters individually for each call.It also generalizes the logic of deriving the
SCHEMAandTABLEproperties from the table name. We will be able to modify it in a single place once the table name becomes represented withOptionallyQualifiedNameinstead ofstring.Additionally, it marks all methods declared as internal in #6788 as private.