Merge 4.2.x up into 4.3.x

.github/workflows/continuous-integration.yml

@@ -521,17 +521,15 @@ jobs:
           LICENSE: "accept"
           DBNAME: "doctrine"
 
-        options: >-
-          --health-cmd "su - ${DB2INSTANCE} -c \"db2 -t CONNECT TO ${DBNAME};\""
-          --health-interval 30s
-          --health-timeout 10s
-          --health-retries 5
-          --privileged
+        options: "--privileged"
 
         ports:
           - "50000:50000"
 
     steps:
+      - name: "Perform healthcheck"
+        run: "docker logs -f ${{ job.services.ibm_db2.id }} | sed '/(*) Setup has completed./ q'"
+
       - name: "Create temporary tablespace"
         run: "docker exec ${{ job.services.ibm_db2.id }} su - db2inst1 -c 'db2 -t CONNECT TO doctrine; db2 -t CREATE USER TEMPORARY TABLESPACE doctrine_tbsp PAGESIZE 4 K;'"
 

src/Driver/SQLSrv/Result.php

@@ -106,7 +106,7 @@ public function free(): void
         // @link http://php.net/manual/en/pdostatement.closecursor.php
         // @link https://github.com/php/php-src/blob/php-7.0.11/ext/pdo/pdo_stmt.c#L2075
         // deliberately do not consider multiple result sets, since doctrine/dbal doesn't support them
-        while (sqlsrv_fetch($this->statement)) {
+        while (sqlsrv_fetch($this->statement) === true) {
         }
     }
 

src/Schema/SQLServerSchemaManager.php

@@ -156,7 +156,7 @@ protected function _getPortableTableColumnDefinition(array $tableColumn): Column
 
     private function parseDefaultExpression(string $value): ?string
     {
-        while (preg_match('/^\((.*)\)$/s', $value, $matches)) {
+        while (preg_match('/^\((.*)\)$/s', $value, $matches) === 1) {
             $value = $matches[1];
         }
 

tests/Functional/Driver/OCI8/ResultTest.php

@@ -100,7 +100,7 @@ public function testTruncatedFetch(
         }
 
         try {
-            while ($result->fetchOne()) {
+            while ($result->fetchOne() !== false) {
                 // Attempt to access all remaining rows from the original fetch
                 // The rows locally cached from the default prefetch will first be used
                 // but when the result attempts to get the remaining 10 rows beyond

tests/Functional/PortabilityTest.php

@@ -36,15 +36,15 @@ public function testFullFetchMode(): void
 
         $result = $this->connection->executeQuery('SELECT * FROM portability_table');
 
-        while (($row = $result->fetchAssociative())) {
+        while (($row = $result->fetchAssociative()) !== false) {
             $this->assertFetchResultRow($row);
         }
 
         $result = $this->connection
             ->prepare('SELECT * FROM portability_table')
             ->executeQuery();
 
-        while (($row = $result->fetchAssociative())) {
+        while (($row = $result->fetchAssociative()) !== false) {
             $this->assertFetchResultRow($row);
         }
     }