Deprecate "version" column platform option#6940
Merged
morozov merged 1 commit intodoctrine:4.3.xfrom May 2, 2025
Merged
Conversation
greg0ire
reviewed
May 2, 2025
| 'doctrine/dbal', | ||
| 'https://github.com/doctrine/dbal/pull/6940', | ||
| 'The "version" column platform option is deprecated.', | ||
| __METHOD__, |
Member
There was a problem hiding this comment.
There is no sprintf placeholder for this parameter.
greg0ire
approved these changes
May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #6939 for more context.
The
versionoption is undocumented, untested, and it's hard to tell what it's supposed to do given the name. My best guess is that it makes the platform use a type analogous toTIMESTAMPbut with the default value equal to "now". From the old JIRA on the internet archive (I cannot find the link), it looks like a leftover from the times when the ORM and the DBAL were a single project, so this option was meant to support some versioning.We deprecated and removed the "now" functionality in #4753.