Populate indexed column lengths only with non-null values#6965
Merged
morozov merged 1 commit intodoctrine:4.3.xfrom May 20, 2025
Merged
Populate indexed column lengths only with non-null values#6965morozov merged 1 commit intodoctrine:4.3.xfrom
morozov merged 1 commit intodoctrine:4.3.xfrom
Conversation
greg0ire
approved these changes
May 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is similar to #6964. If an index is constructed via
IndexEditor, even if none of the indexed columns have the length specified, its$optionswill have alengthelement populated with nulls. This isn't a problem per se but may fail the results of comparison of the expected index constructed vianew Index()and the actual constructed viaIndexEditor.Without the code change in
IndexEditor, the rewritten test would fail.On its own, the current behavior isn't right or wrong. The MySQL schema manager also populates all column lengths, even if they are null.