Include WHERE clause in auto-generated partial index names - #7429
Open
mikoajp wants to merge 1 commit into
Open
Conversation
Partial indexes on the same columns but with different WHERE clauses were getting the same auto-generated name, causing conflicts in schema diff and migrations. Fix by including the WHERE clause in the hash used to generate the index name when no explicit name is provided. Fixes doctrine#7169
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Include the
WHEREclause in the auto-generated index name hash to prevent collisions between partial indexes defined on the same columns.