Compare the introspected table to the declared one - #7480
Merged
Conversation
The comparator takes the current schema first and the desired one second. Several tests had them the other way round.
greg0ire
approved these changes
Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several tests introspect a table and compare it against the schema they declared, but pass the arguments the wrong way round: the declared table first, the introspected one second.
The comparator takes the current schema first and the desired one second, and the comparison isn't symmetric. Some of this asymmetry was introduced #4746 and some more may be introduced in #7477 (e.g. indexes automatically created by the database are expected to exist in the database but not in the application schema).