docs: setFirstResult()/setMaxResults() only apply to SELECT queries - #7506
Open
Amoifr wants to merge 1 commit into
Open
docs: setFirstResult()/setMaxResults() only apply to SELECT queries#7506Amoifr wants to merge 1 commit into
Amoifr wants to merge 1 commit into
Conversation
The limit emulation only exists for SELECT: on UPDATE and DELETE the methods are silently ignored, since vendor-specific syntax such as MySQL's DELETE ... LIMIT has no portable equivalent. Fixes doctrine#7119
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documents in the Limit Clause section of the query builder reference that
setFirstResult()/setMaxResults()only apply toSELECTqueries and are ignored onUPDATE/DELETE, as requested in #7119: vendor-specific syntax such as MySQL'sDELETE ... LIMIThas no portable equivalent, so the query builder does not emulate the clause there. Also points to theWHERE-clause alternative (restricting to a set of primary keys selected beforehand).