Support adding fields in make command - #10
Merged
Conversation
GromNaN
reviewed
Feb 4, 2026
| return; | ||
| } | ||
|
|
||
| $newPropertyBuilder = (new Builder\Property($name))->makePublic(); |
Member
There was a problem hiding this comment.
The public property is conform to what we expect.
Note that for to-many relationships, we want to use private(set) Collection $propName; which we will modify later.
paulinevos
force-pushed
the
add-fields
branch
2 times, most recently
from
February 6, 2026 12:11
dca81b4 to
edf935d
Compare
paulinevos
changed the title
paulinevos
changed the title
paulinevos
force-pushed
the
add-fields
branch
2 times, most recently
from
February 9, 2026 15:43
ac3e3a3 to
d58577d
Compare
paulinevos
changed the title
GromNaN
reviewed
Feb 9, 2026
Member
|
You can update the default id field, to make it public and remove the setter. It's declared in templates/mongodb/Document.tpl.php |
paulinevos
force-pushed
the
add-fields
branch
from
February 11, 2026 10:04
d58577d to
f22d771
Compare
paulinevos
force-pushed
the
add-fields
branch
from
February 11, 2026 10:10
f22d771 to
3118fb3
Compare
GromNaN
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.