[RFC] add HydrationFactory as extension point for tracking hydrations - #12059
Closed
kbond wants to merge 1 commit into
Closed
[RFC] add HydrationFactory as extension point for tracking hydrations#12059kbond wants to merge 1 commit into
kbond wants to merge 1 commit into
Conversation
Contributor
|
There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. |
Contributor
|
This pull request was closed due to inactivity. |
Contributor
Author
|
I'd like to keep this open for consideration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Continuation of #9545)
This is a proposed extension point to help solve doctrine/DoctrineBundle#109. I'm thinking a
HydratorInterfacethatAbstractHydratorimplements should be added but wanted to get some feedback/input before going further.The doctrine bundle could use this to add hydration times to the timeline:
The doctrine bundle could add something similar to https://github.com/debesha/DoctrineProfileExtraBundle#screenshots to the profiler panel.
You can see an example of how this could be used in DoctrineBundle here: https://github.com/kbond/symfony-reproducer/tree/hydration-profiler-poc (specifically kbond/symfony-reproducer@9a4e91b).
I don't think this causes any performance problems for hydration (when using the
DefaultHydratorFactory).