Merged
Conversation
derrabus
force-pushed
the
improvement/ci-with-symfony-8
branch
4 times, most recently
from
0cf208d to
4db444d
Compare
xabbuh
reviewed
Aug 5, 2025
| #[WithoutErrorHandler] | ||
| public function testProxyFactoryTriggersDeprecationWhenNativeLazyObjectsAreDisabled(): void | ||
| { | ||
| if (! method_exists(ProxyHelper::class, 'generateLazyGhost')) { |
Member
There was a problem hiding this comment.
What about using #[RequiresMethod(ProxyHelper::class, 'generateLazyGhost')] instead?
3 tasks
derrabus
force-pushed
the
improvement/ci-with-symfony-8
branch
from
4db444d to
6683eb9
Compare
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Aug 6, 2025
* 3.6.x: Run tests with Symfony 8 (doctrine#12102) Improve comment Convert test into 2 unit tests Quote parts of the table name
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Aug 6, 2025
* 3.6.x: Run tests with Symfony 8 (doctrine#12102) Improve comment Convert test into 2 unit tests Quote parts of the table name
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Aug 6, 2025
* 3.6.x: Include stability in coverage file key (doctrine#12112) Allow Symfony 8 (doctrine#12110) Run tests with Symfony 8 (doctrine#12102) Improve comment Convert test into 2 unit tests Quote parts of the table name
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symfony 8 will be released in November this year and we should monitor if we're compatible.