Comparison like/notlike support

[Fedik]

Support Comparison::LIKE and Comparison::NOTLIKE additionally to doctrine/collections#50

as alternative for #1150

[doctrinebot]

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DDC-3446

We use Jira to track the state of pull requests and the versions they got
included in.

[stof]

The usage of the constants to define the array would bump the requirement on doctrine/collections. Couldn't you use the value of the constant instead (eventually putting a comment with the constant in it), so that it works fine for older versions of doctrine/collections too (people would oviously not be passing the LIKE operator if they don't have it, but it would not break things for other operators)

[stof]

another thing which is necessary (but probably as a separate PR) is fixing the SQL conversion of the CONTAINS operator (it needs to escape the placeholders in the value)

[Fedik]

sorry, I not very understand your first suggestion

about second, I think it out of scope for current pull,
fix the CONTAINS better separately, also I not sure how to do it .. first thinking is use preg_replace, but then better stay as is 😄

[stof]

My first suggestion is to write the code this way:

    'LIKE' => 'LIKE %s', // Comparison::LIKE
    'NOTLIKE' => 'NOT LIKE %s', // Comparison::NOT_LIKE

This way, it will still be possible to use the ORM with older versions of Doctrine Collections which does not have these constants.

For CONTAINS, the fix is to escape placeholders in the value when building the SQL parameters, so that a % in the value matches only a %

[github-actions]

There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days.
If you want to continue working on it, please leave a comment.

[Fedik]

pr is updated for 3.x