Make default string length of 255 configurable in SchemaTool.#12206
Draft
beberlei wants to merge 1 commit intodoctrine:3.7.xfrom
Draft
Make default string length of 255 configurable in SchemaTool.#12206beberlei wants to merge 1 commit intodoctrine:3.7.xfrom
beberlei wants to merge 1 commit intodoctrine:3.7.xfrom
Conversation
stof
reviewed
Oct 10, 2025
|
|
||
| public function getDefaultStringTypeSchemaLength(): ?int | ||
| { | ||
| return $this->attributes['defaultStringTypeSchemaLength'] ?? 255; |
Member
There was a problem hiding this comment.
this can never return null Setting null through the setter is not respected by the getter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unsure about the problem space yet, since our assumption was that ORM does not set the default to 255 yet, but apparently it does here in SchemaTool for type === 'string'.
Fixes #12205