[Cache] pass $hints through to unit of work alongside default ones in DefaultQueryCache#12295
Open
dciprian-petrisor wants to merge 1 commit intodoctrine:3.7.xfrom
Open
[Cache] pass $hints through to unit of work alongside default ones in DefaultQueryCache#12295dciprian-petrisor wants to merge 1 commit intodoctrine:3.7.xfrom
dciprian-petrisor wants to merge 1 commit intodoctrine:3.7.xfrom
Conversation
…QueryCache The existing $hints parameter for a QueryCache's get and put methods were not passed along to the unit of work. Instead, a static array of $hints which only specifies the doctrine.cache.enabled hint was always passed in. With this change, the DefaultQueryCache allows passing hints to the UoW when it is hydrating entities from cache data. For example, the REFRESH hint could be used to indicate that the cache data should be used to update the already existing object in the identity map.
Member
|
Can you elaborate why you need this change? A functional test could also help me understand your use-case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing $hints parameter for a QueryCache's get and put methods were not passed along to the unit of work. Instead, a static array of $hints which only specifies the doctrine.cache.enabled hint was always passed in.
With this change, the DefaultQueryCache allows passing hints to the UoW when it is hydrating entities from cache data.
For example, the REFRESH hint could be used to indicate that the cache data should be used to update the already existing object in the identity map (my current use-case/need for this).