12225 Fix hydration issue when using indexBy, SQL filter, and inheritance mapping#12373
Open
tomme87 wants to merge 6 commits intodoctrine:2.20.xfrom
Open
12225 Fix hydration issue when using indexBy, SQL filter, and inheritance mapping#12373tomme87 wants to merge 6 commits intodoctrine:2.20.xfrom
tomme87 wants to merge 6 commits intodoctrine:2.20.xfrom
Conversation
This fixes an issue with a hydration error when fetching on-to-many relationship with a indexBy definition when using inheritance mapping. Fixes doctrine#12225
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #12225 we get an "Uncaught ErrorException: Undefined array key" error when using trying to initialize a one-to-many collection with indexBy on entity with inheritance mapping and is enabling/disabling SQL filters.
This is an alternative solution instead of #12228 which follows how this was solved in #11792
(Instead of altering
ResultSetMapping::addIndexBy()to use the last found column name, we prevent adding additional column names for the same field)Fixes #12225