Mark callable parameters with @param-immediately-invoked-callable#12397
Open
janedbal wants to merge 2 commits intodoctrine:3.6.xfrom
Open
Mark callable parameters with @param-immediately-invoked-callable#12397janedbal wants to merge 2 commits intodoctrine:3.6.xfrom
janedbal wants to merge 2 commits intodoctrine:3.6.xfrom
Conversation
…invoked-callable This allows PHPStan to properly propagate checked exceptions and impurity from callbacks that are invoked immediately. See https://phpstan.org/writing-php-code/phpdocs-basics#callables
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the
@param-immediately-invoked-callablePHPStan annotation to all callable parameters that are invoked immediately.Changed methods
EntityManagerInterface::wrapInTransaction()— callable is invoked immediately within the transactionUnitOfWork::performCallbackOnCachedPersister()— callable is invoked immediately in a loop