Fix broken AUTOGENERATE_FILE_NOT_EXISTS_OR_CHANGED proxy setting.#12491
Open
demiankatz wants to merge 1 commit into
Open
Fix broken AUTOGENERATE_FILE_NOT_EXISTS_OR_CHANGED proxy setting.#12491demiankatz wants to merge 1 commit into
demiankatz wants to merge 1 commit into
Conversation
demiankatz
force-pushed
the
fix-issue-11418
branch
2 times, most recently
from
bb6cbbe to
6397910
Compare
demiankatz
force-pushed
the
fix-issue-11418
branch
from
6397910 to
334c6d2
Compare
This was referenced May 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the problem described by issue #11418 by replacing a buggy
switchstatement with a (hopefully) clearer and less problematicmatchstatement. Apart from fixing the bug of the non-functioningAUTOGENERATE_FILE_NOT_EXISTS_OR_CHANGEDsetting, this should cause no changes to behavior.I apologize for not including a test case with this fix; because of the nature of the functionality (which depends on file modification times and results in disk writes), it is impractical to write a unit test without refactoring things to allow mocking. I thought keeping the test focused and simple was a greater priority, but I am open to discussing more complex changes if that would be desirable.
I am a first-time contributor, so please feel free to make suggestions, and please accept my apologies if I've overlooked or misunderstood anything from the contribution guidelines.