Fix hydration of collections indexed by an inherited field when SQL filters change - #12506
Open
igrizzli wants to merge 1 commit into
Open
Fix hydration of collections indexed by an inherited field when SQL filters change#12506igrizzli wants to merge 1 commit into
igrizzli wants to merge 1 commit into
Conversation
igrizzli
commented
Jun 10, 2026
igrizzli
commented
| Q | A |
|---|---|
| Type | bug |
| BC Break | no |
| Fixed issues | Fixes #12505 |
greg0ire
previously requested changes
Jun 10, 2026
greg0ire
left a comment
greg0ire
left a comment
Member
There was a problem hiding this comment.
According to https://www.doctrine-project.org/2025/10/08/an-update-on-the-orm-2-end-of-life.html, we no longer accept bugfixes on 2.x
Please retarget to 3.x if it is affected.
igrizzli
force-pushed
the
12505-reuse-inherited-column-alias
branch
from
June 11, 2026 02:25
86b39c6 to
05397db
Compare
greg0ire
reviewed
Jun 11, 2026
Member
Contributor
|
Its OK, I am approve. |
This fixes a hydration error ("Undefined array key") when loading a
collection indexed by an inherited field after the SQL filters
changed. The column alias reuse from doctrine#11792/doctrine#12373 stores the alias
under the field's declaring class but looks it up under the alias's
class, so it never matches for inherited fields.
Fixes doctrine#12505
igrizzli
force-pushed
the
12505-reuse-inherited-column-alias
branch
from
June 25, 2026 17:09
05397db to
cdc1267
Compare
greg0ire
reviewed
Jun 26, 2026
| public function setDeletedAt(DateTimeImmutable|null $deletedAt): void | ||
| { | ||
| $this->deletedAt = $deletedAt; | ||
| } |
Member
There was a problem hiding this comment.
Please remove any unused methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.