Add @no-named-arguments to QueryBuilder select and group helpers - #12513
Open
savinmikhail wants to merge 1 commit into
Open
Add @no-named-arguments to QueryBuilder select and group helpers#12513savinmikhail wants to merge 1 commit into
savinmikhail wants to merge 1 commit into
Conversation
savinmikhail
marked this pull request as ready for review
June 20, 2026 04:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
@no-named-argumentsto the variadicQueryBuilderhelpers used for projections and grouping:select()addSelect()groupBy()addGroupBy()Why this is separate from #12512
I split this out from the
where()/having()condition helpers on purpose.The first PR focused on the most obvious condition-building methods, where named arguments are especially misleading for the variadic predicate-style API and where there is already a related bug signal in #11253.
This PR covers a second group of variadic helpers where the main concern is API contract clarity and tooling guidance: the parameter names are still implementation details rather than something that should be treated as a stable named-argument contract.
Related
Validation
vendor/bin/phpunit tests/Tests/ORM/QueryBuilderTest.phpvendor/bin/phpcs --standard=phpcs.xml.dist src/QueryBuilder.php