Ignore deprecation from DBAL - #12524
Merged
Merged
Conversation
Deprecations with this particular identifier are numerous and hard to address. Addressing them might require new configuration, or even new deprecations. I think we should address them in the next minor branch. Let us ignore them until that is the case. We may still send changes addressing such deprecations when they emanate from tests.
Member
Author
|
Example of what's needed to address only some of the deprecations: #12523 |
SenseException
approved these changes
Jul 1, 2026
SenseException
left a comment
SenseException
left a comment
Member
There was a problem hiding this comment.
The plan is to remove this line again in the next minor branch with the needed fixes?
Member
|
Yeah, it's one large deprecation. I tried to give different deprecations within the same PR unique identifiers once (doctrine/dbal#6677), but that was quite tedious, so I didn't do that anymore. |
morozov
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecations with this particular identifier are numerous and hard to address. Addressing them might require new configuration, or even new deprecations. I think we should address them in the next minor branch. Let us ignore them until that is the case.
We may still send changes addressing such deprecations when they emanate from tests.