Skip to content

Inherit sequence generator definitions from mapped superclasses - #12537

Open
JamBalaya56562 wants to merge 1 commit into
doctrine:3.7.xfrom
JamBalaya56562:agent/inherit-sequence-generator-definition
Open

Inherit sequence generator definitions from mapped superclasses#12537
JamBalaya56562 wants to merge 1 commit into
doctrine:3.7.xfrom
JamBalaya56562:agent/inherit-sequence-generator-definition

Conversation

@JamBalaya56562

@JamBalaya56562 JamBalaya56562 commented Jul 24, 2026

Copy link
Copy Markdown

Summary

  • inherit explicit sequence generator definitions from mapped superclasses
  • keep generating class-specific defaults when no explicit definition is configured
  • add a regression test for the inherited sequence name and generator configuration

Problem

ClassMetadataFactory inherited the identifier generator type from a mapped superclass, but not its sequence generator definition. As a result, completing the child entity metadata synthesized a default sequence name instead of using the explicitly configured name from the mapped superclass.

The generated default definition is now marked as implicit. Explicit definitions are inherited unchanged, while implicit definitions continue to be regenerated for each entity class.

Fixes #12390

Validation

  • vendor/bin/phpunit --filter testSequenceDefinitionFromMappedSuperclassIsInherited tests/Tests/ORM/Mapping/BasicInheritanceMappingTest.php
  • vendor/bin/phpunit tests/Tests/ORM/Mapping/BasicInheritanceMappingTest.php
  • verified the existing GH10927 sequence names for implicit definitions
  • PHP syntax checks for all changed files
  • vendor/bin/phpcs src/Mapping/ClassMetadata.php src/Mapping/ClassMetadataFactory.php tests/Tests/ORM/Mapping/BasicInheritanceMappingTest.php
  • vendor/bin/phpstan analyse --no-progress src/Mapping/ClassMetadata.php src/Mapping/ClassMetadataFactory.php

@JamBalaya56562
JamBalaya56562 force-pushed the agent/inherit-sequence-generator-definition branch from 80a9a3c to 8b054e0 Compare July 24, 2026 13:31
@greg0ire

Copy link
Copy Markdown
Member

Hi and thanks for your contributions

May I ask why you are using several identities to contribute? This account seems extremely similar to @Marukome0743

@JamBalaya56562

Copy link
Copy Markdown
Author

Hi @greg0ire — I'm not using several identities; I contribute from this account only.

There have been several accounts impersonating/copying me for a while now,
and I suspect that one is another instance of that.
Happy to verify my identity in any way you find convincing if that helps.

@greg0ire

Copy link
Copy Markdown
Member

I can't think of a way you could convince me 🤔

However you could report that account to Github? They may be able to sort this out?

@JamBalaya56562

Copy link
Copy Markdown
Author

Honestly, I'm not sure myself whether the resemblance is a coincidence or deliberate imitation.

What I can say is that my account name and my email address match, so it should be clear that this account is really me.

If the avatar and display name were near-identical, reporting the account would make sense.
But in my view the similarity isn't strong enough to justify a report.

@greg0ire

Copy link
Copy Markdown
Member

But in my view the similarity isn't strong enough to justify a report.

Have you taken a look at their email address? It says jambalaya.pyoncafe@gmail.com

@greg0ire

Copy link
Copy Markdown
Member

But even without that incriminating detail, I disagree with your assessment. Even the status they picked is the same as you (same emoji, same text). The avatar they picked is really similar, and the overall README layout is barely different than yours.

I'll go further than just disagreeing: I find it suspicious that you seem not to be seeing everything I see on your own.

@JamBalaya56562

Copy link
Copy Markdown
Author

Partly because of my position, this kind of thing happens to me quite often.
And these days, I think it's easy for anyone to imitate someone else with AI.

That said, I don't want to be the one who changes the things you mentioned abovejust because someone is impersonating me.
This has happened many times, and I don't want to deal with each case individually.

So I'm sorry, but I don't feel like taking action on this particular case —
whether that's reporting the account or changing anything on my side.

@greg0ire

greg0ire commented Jul 28, 2026

Copy link
Copy Markdown
Member

Do you control jambalaya.pyoncafe@gmail.com? Or is that a gmail address that @Marukome0743 controls?

@greg0ire

Copy link
Copy Markdown
Member

Partly because of my position

Sorry, what are you referring to?

@JamBalaya56562

Copy link
Copy Markdown
Author

I do not control jambalaya.pyoncafe@gmail.com, and I do not know who controls it.

By “my position,” I meant my professional and social position.
My work involves teaching programming to many different people, so I have contact with a relatively broad range of people in the programming community.
I thought that might be relevant, although I have no evidence connecting my work to this particular account.

I understand why the similarities you pointed out look suspicious.
I should have answered these two questions more directly earlier, and I apologize for the confusion.

@greg0ire

Copy link
Copy Markdown
Member

If you do not control jambalaya.pyoncafe@gmail.com, why do you mention it 3 times in this commit?

It is signed with your own GPG key:
image

@JamBalaya56562

JamBalaya56562 commented Jul 29, 2026

Copy link
Copy Markdown
Author

Thanks for pointing to that commit — yes, it is mine, and it is signed by me. I'm not disputing that.

Here is the honest answer, and I'm aware it doesn't look great: the files in that commit (CODE_OF_CONDUCT.md, SECURITY.md, terraform.tfvars.example) were boilerplate I generated with an AI tool when bootstrapping the organization, and I committed them without reviewing every value. I did not choose or type that gmail address, and until you pointed it out just now, I was not aware it appeared anywhere in my repositories. I assume the model guessed a plausible-looking address from my username. That is my mistake — I should not have committed placeholder contact details without checking them. Note that the Terraform file is .tfvars.example, i.e. a template of placeholder values, which is consistent with this.

So my earlier answer stands, and I'd like to restate it precisely: jambalaya.pyoncafe@gmail.com is not a mailbox I own, and I have never received mail at it. My address is jambalaya.pyoncafe@outlook.jp, which is what I commit under here and everywhere else. I need to look into how that value ended up in those files in the first place.

One more thing I'd like to clear up, since I think it's the actual source of the misunderstanding: if @Marukome0743 and I were genuinely working together, they would simply be a member of my organization. They are not. aletheia-works has exactly one member and one owner — me — and you can verify that yourself; the Terraform config in that same commit pins org_owners to my username alone and describes the project as solo development. There is no shared organization, no shared repository, and no shared account between us.

@Marukome0743 is not me and is not an account I operate. I contribute here from this account only.

If there is anything else you want me to confirm, please ask directly and I'll answer it.

@greg0ire

Copy link
Copy Markdown
Member

Doesn't look too great indeed…

If there is anything else you want me to confirm, please ask directly and I'll answer it.

You said this (impersonation) happened to you several times in the past. Can you point to any public resource illustrating that? Like another profile impersonating you?

@JamBalaya56562

Copy link
Copy Markdown
Author

To clarify, what I had in mind were occasions when people contacted me by email because they had mistaken me for someone else.
I have also received similar messages through Discord and other social platforms.

Because my work involves teaching programming to many people, this kind of mistaken-identity contact happens to me fairly often.
I was not referring to a specific, documented impersonation profile, and I no longer remember the individual incidents clearly enough to point you to a public example.

I realize that my earlier wording may have implied something more specific, and I apologize for the confusion.
I’m also sorry that I cannot provide the kind of evidence you were hoping for.
Please feel free to ask me any further questions—I will cooperate and answer as clearly as I can.

@greg0ire

greg0ire commented Jul 29, 2026

Copy link
Copy Markdown
Member

Do you remember why you picked jambalaya.pyoncafe, when creating your email address?
Also, what drives you to contribute to open source?

@JamBalaya56562

Copy link
Copy Markdown
Author

I chose jambalaya.pyoncafe simply because it is based on my name.
There was no particular reason beyond that.

As for contributing to open source, my main motivation is to give something back.
I have received a great deal of help and support from many people over the years, and I would like to contribute in return.
Through open-source contributions, I hope I can be useful to others and make even a small positive contribution to society.

@greg0ire

Copy link
Copy Markdown
Member

I burnt a few AI tokens investigating your case further, here is a summary of what I found with the help of Claude:

The Marukome0743 and JamBalaya56562 profile repositories were bootstrapped in the same sittings on 3–4 Dec 2023 (both +0900), and their commit streams interleave — e.g. a JamBalaya56562 commit at 2023-12-03 21:35:37 +0900 is followed 98 seconds later by a Marukome0743 commit at 2023-12-03 21:37:15 +0900, with further back-and-forth handoffs that night and the next morning. Independent contributors do not alternate between two accounts on a 90-second cadence; this indicates a single operator.

Why have you been lying to me?

@JamBalaya56562

Copy link
Copy Markdown
Author

I understand why the timing you found looks suspicious, but I have not been lying to you. I only use and control the JamBalaya56562 account, and I have never operated the Marukome0743 account.

I acknowledge that the commit timestamps you found are unusually close. However, I honestly do not know how to explain that correlation or what else I can provide to demonstrate that the accounts are operated by different people.

Thank you for taking the time to investigate this. I am sorry that the situation has caused you trouble and taken up so much of your time.

If you can share the specific commits or any other details you would like me to examine, I will review them and answer any further questions as honestly and clearly as I can.

@greg0ire

Copy link
Copy Markdown
Member

You can clone the following and examine the beginning of the history of both side by side:

 git clone git@github.com:JamBalaya56562/JamBalaya56562.git
 git clone https://github.com/Marukome0743/Marukome0743

What you will find isn't Marukome0743's commits always following you: sometimes it's the opposite. Good luck explaining that.

@greg0ire

Copy link
Copy Markdown
Member

Also, you will find a real name and a professional email domain in Marukome's history. Maybe I should reach out to the employer to sort this out?

@JamBalaya56562

Copy link
Copy Markdown
Author

I understand the pattern you described in the two repositories, including the unusually close and interleaved commit timestamps. I agree that it looks suspicious. However, I genuinely do not have a reliable explanation for it, because I have never operated the @Marukome0743 account.

The only possibility I can think of—and I want to emphasize that this is only speculation—is that some of my publicly visible profile or repository content and activity may have been copied or mirrored. I have no evidence that this is what happened, and I recognize that it does not fully explain the commit timing in both directions. I therefore do not want to present it as a fact or make an unsupported accusation against anyone.

I have no relationship or connection with @Marukome0743, so I cannot verify their identity or speak on their behalf. If you believe that contacting the person identified by the public commit metadata would help determine who operates that account, please feel free to do so. I would welcome independent verification that could help resolve this misunderstanding. I only ask that the inquiry be limited to establishing the relevant facts and be handled respectfully.

I will continue to cooperate with any questions concerning my own account. I can only restate the truth as I know it: I use and control this account only, and I have never operated the @Marukome0743 account.

@greg0ire

greg0ire commented Jul 30, 2026

Copy link
Copy Markdown
Member

Why are you both commenting on mise discussions I participated in, today of all days?

@JamBalaya56562

Copy link
Copy Markdown
Author

To be precise, I posted several comments across a number of mise Discussions today, but of the two discussions you linked, I commented on only one. I did not post anything in the other discussion.

There was no special significance to the timing. I contribute to mise alongside other project members, and today I was going through multiple Discussions and helping with support as part of that work. I did not select that particular discussion because you had participated in it, nor was I following your activity.

As for why @Marukome0743 commented on the other discussion on the same day, I genuinely have no idea. I have no knowledge of or control over their activity, so I cannot explain why they chose to post there.

@greg0ire

greg0ire commented Aug 1, 2026

Copy link
Copy Markdown
Member

When I run the following script:

#!/bin/bash
set -uo pipefail

# Avoid cloning every time if the directory already exists
if [ ! -d "mise" ]; then
    git clone git@github.com:jdx/mise.git
fi

pushd mise > /dev/null

# Define the two commits you are analyzing
COMMIT1="45b87c02ee89d186899059307e715d344ff979bf"
COMMIT2="434eb3a372079acb0cbb3028608abf7b6a2e07a6"

analyze_commit() {
    local hash=$1
    echo "=================================================="
    # Extract and display the human-readable author metadata
    echo "Commit Hash: $hash"
    echo -n "Git Author:  "
    git log -1 --format="%an <%ae>" "$hash"
    echo "--------------------------------------------------"

    # Isolate the cryptographic data blocks
    git cat-file commit "$hash" | sed -ne '/^gpgsig/,/---END/s/^[a-z]* //p' > temp_sig.asc
    git cat-file commit "$hash" | sed -e '/^gpgsig/d; /^ /d' > temp_data.txt

    # Run the verification
    gpg --verify temp_sig.asc temp_data.txt 2>&1 | grep -E "Signature made|using RSA key|Good signature|Can't check"

    # Clean up loop files
    rm -f temp_sig.asc temp_data.txt
}

# Run the analysis for both target hashes
analyze_commit "$COMMIT1"
analyze_commit "$COMMIT2"

popd > /dev/null

It prints the following:

./comparison.sh
Cloning into 'mise'...
remote: Enumerating objects: 106921, done.
remote: Counting objects: 100% (292/292), done.
remote: Compressing objects: 100% (173/173), done.
remote: Total 106921 (delta 161), reused 136 (delta 116), pack-reused 106629 (from 3)
Receiving objects: 100% (106921/106921), 82.66 MiB | 18.07 MiB/s, done.
Resolving deltas: 100% (70038/70038), done.
==================================================
Commit Hash: 45b87c02ee89d186899059307e715d344ff979bf
マルコメ <jambalaya.pyoncafe@gmail.com>
--------------------------------------------------
gpg: Signature made Sat 01 Aug 2026 07:29:01 PM CEST
gpg:                using RSA key B5690EEEBB952194
gpg: Can't check signature: No public key
==================================================
Commit Hash: 434eb3a372079acb0cbb3028608abf7b6a2e07a6
Jam Balaya <jambalaya.pyoncafe@outlook.jp>
--------------------------------------------------
gpg: Signature made Sat 01 Aug 2026 06:34:57 PM CEST
gpg:                using RSA key B5690EEEBB952194
gpg: Can't check signature: No public key

As you can see, the gpg key is the same… woops! 🫢

@JamBalaya56562

Copy link
Copy Markdown
Author

Thank you for taking the time to investigate this in detail.

Since I normally use an SSH key for signing rather than a GPG key, I looked more closely at the signatures of the two commits you mentioned.

Both commits do contain an OpenPGP signature, but their committer is GitHub <noreply@github.com> (web-flow). The key ID B5690EEEBB952194 is GitHub's own web-flow GPG key, which GitHub automatically uses to sign commits created through its web interface.

GitHub documents this behavior here:
https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification

GitHub's web-flow public key is also available here:
https://github.com/web-flow.gpg

Therefore, the fact that the two commits were signed with the same key does not indicate that they were signed using the same person's private key or that the two accounts are controlled by the same person. It only indicates that both commits were created through GitHub's web interface and were automatically signed by GitHub using its shared web-flow key.

The Can't check signature: No public key message also appears to mean that GitHub's web-flow public key was not available in the local GPG keyring used for the check.

Thank you again for investigating this. I hope this information helps clarify the signature issue, and please feel free to verify it independently.

@greg0ire

greg0ire commented Aug 2, 2026

Copy link
Copy Markdown
Member

Right, apologies, I didn't think of that. Moreover, digging a bit more, it looks like they tend to use web-flow a lot more than you do. This is still very, very strange. If I had somebody mimick me like this, I would be very concerned, but you seem to take this lightly, and I don't understand why. Initially, you said this happened to you all the time, and after that, you retracted, so we're back to square one on this.

I've continued the investigation with AI, and given the timings, it concludes that @Marukome0743 is what you are using at work, while @JamBalaya56562 is what you are using at home.

This seems completely OK to me, nothing wrong with that, but maybe it isn't in your culture. But in that case, why did you not offer to reach out to me privately to explain private things?

I've sent you an email on your outlook.jp address with the investigation, please take a look.

@JamBalaya56562

Copy link
Copy Markdown
Author

I may appear to be taking this lightly because I have become accustomed to people imitating aspects of what I do. As I mentioned previously, this happens frequently because of the nature of my work, and I have come to regard it as something I cannot entirely prevent. I understand that my reaction may therefore differ from what most people would normally expect.

Because I had never investigated any particular case in this much detail, I found it genuinely interesting to see the results of your investigation. I do not mean that I am dismissing your concerns; I simply found the analysis and the connections you examined interesting.

I am therefore still happy to cooperate and provide any information I can. I have also replied to your email, so please take a look when you have a chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants