Inherit sequence generator definitions from mapped superclasses - #12537
Inherit sequence generator definitions from mapped superclasses#12537JamBalaya56562 wants to merge 1 commit into
Conversation
80a9a3c to
8b054e0
Compare
|
Hi and thanks for your contributions May I ask why you are using several identities to contribute? This account seems extremely similar to @Marukome0743 |
|
Hi @greg0ire — I'm not using several identities; I contribute from this account only. There have been several accounts impersonating/copying me for a while now, |
|
I can't think of a way you could convince me 🤔 However you could report that account to Github? They may be able to sort this out? |
|
Honestly, I'm not sure myself whether the resemblance is a coincidence or deliberate imitation. What I can say is that my account name and my email address match, so it should be clear that this account is really me. If the avatar and display name were near-identical, reporting the account would make sense. |
Have you taken a look at their email address? It says |
|
But even without that incriminating detail, I disagree with your assessment. Even the status they picked is the same as you (same emoji, same text). The avatar they picked is really similar, and the overall README layout is barely different than yours. I'll go further than just disagreeing: I find it suspicious that you seem not to be seeing everything I see on your own. |
|
Partly because of my position, this kind of thing happens to me quite often. That said, I don't want to be the one who changes the things you mentioned abovejust because someone is impersonating me. So I'm sorry, but I don't feel like taking action on this particular case — |
|
Do you control |
Sorry, what are you referring to? |
|
I do not control By “my position,” I meant my professional and social position. I understand why the similarities you pointed out look suspicious. |
|
If you do not control |
|
Thanks for pointing to that commit — yes, it is mine, and it is signed by me. I'm not disputing that. Here is the honest answer, and I'm aware it doesn't look great: the files in that commit ( So my earlier answer stands, and I'd like to restate it precisely: One more thing I'd like to clear up, since I think it's the actual source of the misunderstanding: if @Marukome0743 and I were genuinely working together, they would simply be a member of my organization. They are not. @Marukome0743 is not me and is not an account I operate. I contribute here from this account only. If there is anything else you want me to confirm, please ask directly and I'll answer it. |
|
Doesn't look too great indeed…
You said this (impersonation) happened to you several times in the past. Can you point to any public resource illustrating that? Like another profile impersonating you? |
|
To clarify, what I had in mind were occasions when people contacted me by email because they had mistaken me for someone else. Because my work involves teaching programming to many people, this kind of mistaken-identity contact happens to me fairly often. I realize that my earlier wording may have implied something more specific, and I apologize for the confusion. |
|
Do you remember why you picked |
|
I chose As for contributing to open source, my main motivation is to give something back. |
|
I burnt a few AI tokens investigating your case further, here is a summary of what I found with the help of Claude:
Why have you been lying to me? |
|
I understand why the timing you found looks suspicious, but I have not been lying to you. I only use and control the JamBalaya56562 account, and I have never operated the Marukome0743 account. I acknowledge that the commit timestamps you found are unusually close. However, I honestly do not know how to explain that correlation or what else I can provide to demonstrate that the accounts are operated by different people. Thank you for taking the time to investigate this. I am sorry that the situation has caused you trouble and taken up so much of your time. If you can share the specific commits or any other details you would like me to examine, I will review them and answer any further questions as honestly and clearly as I can. |
|
You can clone the following and examine the beginning of the history of both side by side: What you will find isn't Marukome0743's commits always following you: sometimes it's the opposite. Good luck explaining that. |
|
Also, you will find a real name and a professional email domain in Marukome's history. Maybe I should reach out to the employer to sort this out? |
|
I understand the pattern you described in the two repositories, including the unusually close and interleaved commit timestamps. I agree that it looks suspicious. However, I genuinely do not have a reliable explanation for it, because I have never operated the @Marukome0743 account. The only possibility I can think of—and I want to emphasize that this is only speculation—is that some of my publicly visible profile or repository content and activity may have been copied or mirrored. I have no evidence that this is what happened, and I recognize that it does not fully explain the commit timing in both directions. I therefore do not want to present it as a fact or make an unsupported accusation against anyone. I have no relationship or connection with @Marukome0743, so I cannot verify their identity or speak on their behalf. If you believe that contacting the person identified by the public commit metadata would help determine who operates that account, please feel free to do so. I would welcome independent verification that could help resolve this misunderstanding. I only ask that the inquiry be limited to establishing the relevant facts and be handled respectfully. I will continue to cooperate with any questions concerning my own account. I can only restate the truth as I know it: I use and control this account only, and I have never operated the @Marukome0743 account. |
|
Why are you both commenting on mise discussions I participated in, today of all days? |
|
To be precise, I posted several comments across a number of mise Discussions today, but of the two discussions you linked, I commented on only one. I did not post anything in the other discussion. There was no special significance to the timing. I contribute to mise alongside other project members, and today I was going through multiple Discussions and helping with support as part of that work. I did not select that particular discussion because you had participated in it, nor was I following your activity. As for why @Marukome0743 commented on the other discussion on the same day, I genuinely have no idea. I have no knowledge of or control over their activity, so I cannot explain why they chose to post there. |
|
When I run the following script: #!/bin/bash
set -uo pipefail
# Avoid cloning every time if the directory already exists
if [ ! -d "mise" ]; then
git clone git@github.com:jdx/mise.git
fi
pushd mise > /dev/null
# Define the two commits you are analyzing
COMMIT1="45b87c02ee89d186899059307e715d344ff979bf"
COMMIT2="434eb3a372079acb0cbb3028608abf7b6a2e07a6"
analyze_commit() {
local hash=$1
echo "=================================================="
# Extract and display the human-readable author metadata
echo "Commit Hash: $hash"
echo -n "Git Author: "
git log -1 --format="%an <%ae>" "$hash"
echo "--------------------------------------------------"
# Isolate the cryptographic data blocks
git cat-file commit "$hash" | sed -ne '/^gpgsig/,/---END/s/^[a-z]* //p' > temp_sig.asc
git cat-file commit "$hash" | sed -e '/^gpgsig/d; /^ /d' > temp_data.txt
# Run the verification
gpg --verify temp_sig.asc temp_data.txt 2>&1 | grep -E "Signature made|using RSA key|Good signature|Can't check"
# Clean up loop files
rm -f temp_sig.asc temp_data.txt
}
# Run the analysis for both target hashes
analyze_commit "$COMMIT1"
analyze_commit "$COMMIT2"
popd > /dev/nullIt prints the following: As you can see, the gpg key is the same… woops! 🫢 |
|
Thank you for taking the time to investigate this in detail. Since I normally use an SSH key for signing rather than a GPG key, I looked more closely at the signatures of the two commits you mentioned. Both commits do contain an OpenPGP signature, but their committer is GitHub documents this behavior here: GitHub's web-flow public key is also available here: Therefore, the fact that the two commits were signed with the same key does not indicate that they were signed using the same person's private key or that the two accounts are controlled by the same person. It only indicates that both commits were created through GitHub's web interface and were automatically signed by GitHub using its shared web-flow key. The Thank you again for investigating this. I hope this information helps clarify the signature issue, and please feel free to verify it independently. |
|
Right, apologies, I didn't think of that. Moreover, digging a bit more, it looks like they tend to use web-flow a lot more than you do. This is still very, very strange. If I had somebody mimick me like this, I would be very concerned, but you seem to take this lightly, and I don't understand why. Initially, you said this happened to you all the time, and after that, you retracted, so we're back to square one on this. I've continued the investigation with AI, and given the timings, it concludes that @Marukome0743 is what you are using at work, while @JamBalaya56562 is what you are using at home. This seems completely OK to me, nothing wrong with that, but maybe it isn't in your culture. But in that case, why did you not offer to reach out to me privately to explain private things? I've sent you an email on your outlook.jp address with the investigation, please take a look. |
|
I may appear to be taking this lightly because I have become accustomed to people imitating aspects of what I do. As I mentioned previously, this happens frequently because of the nature of my work, and I have come to regard it as something I cannot entirely prevent. I understand that my reaction may therefore differ from what most people would normally expect. Because I had never investigated any particular case in this much detail, I found it genuinely interesting to see the results of your investigation. I do not mean that I am dismissing your concerns; I simply found the analysis and the connections you examined interesting. I am therefore still happy to cooperate and provide any information I can. I have also replied to your email, so please take a look when you have a chance. |

Summary
Problem
ClassMetadataFactoryinherited the identifier generator type from a mapped superclass, but not its sequence generator definition. As a result, completing the child entity metadata synthesized a default sequence name instead of using the explicitly configured name from the mapped superclass.The generated default definition is now marked as implicit. Explicit definitions are inherited unchanged, while implicit definitions continue to be regenerated for each entity class.
Fixes #12390
Validation
vendor/bin/phpunit --filter testSequenceDefinitionFromMappedSuperclassIsInherited tests/Tests/ORM/Mapping/BasicInheritanceMappingTest.phpvendor/bin/phpunit tests/Tests/ORM/Mapping/BasicInheritanceMappingTest.phpvendor/bin/phpcs src/Mapping/ClassMetadata.php src/Mapping/ClassMetadataFactory.php tests/Tests/ORM/Mapping/BasicInheritanceMappingTest.phpvendor/bin/phpstan analyse --no-progress src/Mapping/ClassMetadata.php src/Mapping/ClassMetadataFactory.php