Prepare making the DBAL editor API opt-in - #12550
Open
greg0ire wants to merge 1 commit into
Open
Conversation
greg0ire
commented
Aug 6, 2026
Member
Author
|
I guess we won't be making any progress on this today. 
|
greg0ire
force-pushed
the
prepare-opt-in-editor-api
branch
from
August 6, 2026 18:51
df34080 to
c878319
Compare
greg0ire
requested review from
SenseException and
derrabus
and removed request for
SenseException and
derrabus
August 6, 2026 18:52
The migration to the editor API is ongoing, some parts are already released. Some other parts are unreleased but already cause issues to proactive projects that test with dev versions of ORM. I plan to follow this up with a change allowing us to use the editor API in our test suite and only there, until the migration is complete. When it is complete and only then, we should allow users to use it.
greg0ire
force-pushed
the
prepare-opt-in-editor-api
branch
from
August 6, 2026 21:37
c878319 to
e0ea0bc
Compare
greg0ire
commented
Aug 7, 2026
| $this->platform = $em->getConnection()->getDatabasePlatform(); | ||
| $this->quoteStrategy = $em->getConfiguration()->getQuoteStrategy(); | ||
| $this->schemaManager = $em->getConnection()->createSchemaManager(); | ||
| $this->useDbalEditorApi = false; |
Member
Author
There was a problem hiding this comment.
The follow up will make this dynamic, allowing to revert the drop in code coverage.
Member
Author
|
Here is what the follow-up looks like: #12554 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The migration to the editor API is ongoing, some parts are already released. Some other parts are unreleased but already cause issues to proactive projects that test with dev versions of ORM.
I plan to follow this up with a change allowing us to use the editor API in our test suite and only there, until the migration is complete. When it is complete and only then, we should allow users to use it.
Fixes #12549