D8NID-1820 Prison visits: time slot preferences not captured correctly when selected with fast taps on smartphone#1489
Open
neilblair wants to merge 8 commits intodevelopmentfrom
Open
D8NID-1820 Prison visits: time slot preferences not captured correctly when selected with fast taps on smartphone#1489neilblair wants to merge 8 commits intodevelopmentfrom
neilblair wants to merge 8 commits intodevelopmentfrom
Conversation
…lot ranks are correctly captured before form submission
Ensure time and day is announced when timeslot is selected
Belt and braces validation for time slot selection. If for some reason JS has not populated hidden time slot elements, we reset slots and tell user they didn't pick a slot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-working of prison visits JS which handles capturing of users preferred time slots for a visit in rank order. When a user taps a time slot, the process of ranking it (adding a little badge to indicate the order of preference) and the ranks of other time slots is "debounced" so that it completes before the user can tap another time slot or the Next button.