Feature set animation before expand show#58
Open
MohammadEhsanMohit wants to merge 6 commits intodofire:masterfrom
Open
Feature set animation before expand show#58MohammadEhsanMohit wants to merge 6 commits intodofire:masterfrom
MohammadEhsanMohit wants to merge 6 commits intodofire:masterfrom
Conversation
added 5 commits
January 2, 2024 04:35
1. This modification enables animation before expanding the view is shown. 2. Add a new lambda function to the animate method to notify when the animation is done.
This modification uses the new properties of FloatingBubble (animateBeforeExpandViewShow, locationBeforeExpand) to choose whether to animate the bubble view before showing the expanded view.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
In our case, we require the bubble view to move to a specific location before the expand view is shown. I have added some properties that users can set, and when the
expand()function is called, the bubble view animates to the specified location before showing the expand view.Set
isAnimatedBeforeExpandto true: when theexpand()method is called, the bubble view animates to theexpandViewInitialPoint.Also, I have added a new nullable lambda to the
animateTo()function to be called when the animation is finished.fun animateTo( x: Float, y: Float, stiffness: Float = SpringForce.STIFFNESS_MEDIUM, onEnd: (() -> Unit)? = null )Best regards.
/assign_reviewer @TorryDo