Open
Conversation
Collaborator
|
Looks good, I’ll check it out. Thanks for building on libdogecoin! |
edtubbs
requested changes
Feb 10, 2026
Collaborator
edtubbs
left a comment
edtubbs
left a comment
There was a problem hiding this comment.
Recommending a couple changes. Swift builds on Linux (Ubuntu 22.04) after adding -D_GNU_SOURCE.
Co-authored-by: Ed <ectubbs@gmail.com> Signed-off-by: Thomas Rademaker <thomas@radmakr.com>
Co-authored-by: Ed <ectubbs@gmail.com> Signed-off-by: Thomas Rademaker <thomas@radmakr.com>
Author
|
done - I think it is ready for review again. |
edtubbs
approved these changes
Feb 13, 2026
scutuatua-crypto
approved these changes
Mar 24, 2026
scutuatua-crypto
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey team. Not sure if it makes sense to merge this here?
I can always just continue to maintain my fork.
This adds a swift.package and a module map so that libdogecoin can be pulled into a swift project easily.
This stuff is boring and kind of difficult to get right quickly, so I let Claude do it. I reviewed it and it seems fine and it is all additive and shouldn't have any impact on any of the C code.
This branch on my fork is currently powering DogecoinKit
Which is powering DogecoinNodeSync
and the soon to be released Avocadoge