Skip to content

Adding test to verify LDAPS works with ML-DSA#5360

Open
zjshermanburke wants to merge 1 commit into
dogtagpki:masterfrom
zjshermanburke:dogtag_4327_add_test_LDAPS_MLDSA
Open

Adding test to verify LDAPS works with ML-DSA#5360
zjshermanburke wants to merge 1 commit into
dogtagpki:masterfrom
zjshermanburke:dogtag_4327_add_test_LDAPS_MLDSA

Conversation

@zjshermanburke
Copy link
Copy Markdown

@zjshermanburke zjshermanburke commented May 21, 2026

Adding test to verify LDAPS works with ML-DSA per DOGTAG-4327

Summary by CodeRabbit

Chores

  • Enhanced automated testing pipeline with additional security-focused verification tests to strengthen product quality assurance.

Review Change Stack

@gemini-code-assist
Copy link
Copy Markdown

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 21, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ebae1c57-73f3-40d1-b618-38d9a49f365a

📥 Commits

Reviewing files that changed from the base of the PR and between 7092e06 and 997c0e5.

📒 Files selected for processing (1)
  • .github/workflows/ca-tests.yml

📝 Walkthrough

Walkthrough

The PR adds a new GitHub Actions job to the CA tests workflow. The ca-secure-ds-pqc-test job is conditionally enabled on supported distributions, runs after the shared build job, and delegates its test logic to a dedicated reusable workflow.

Changes

CA Test Workflow Configuration

Layer / File(s) Summary
Add PQC secure-DS CA test job
.github/workflows/ca-tests.yml
A new conditional job ca-secure-ds-pqc-test is added that runs post-quantum cryptography tests on the CA with secure data structures, excluding Fedora 42, and reuses the dedicated test workflow at .github/workflows/ca-secure-ds-pqc-test.yml.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Suggested reviewers

  • ladycfu
  • fmarco76

Poem

A rabbit hops through workflows bright,
New PQC tests dance in the night,
Secure-DS structures stand tall and true,
Fedora forty-two skips right through! 🐰✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title describes adding a test for LDAPS with ML-DSA, but the actual changes only add a PQC secure-DS CA test job, not specifically an LDAPS test. Update the title to accurately reflect the changes, such as 'Add CA with secure DS (PQC) test job' or provide clarification on how this relates to LDAPS functionality.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant