Fix GCP assignment failure for STANDARD tier IP addresses#170
Open
javibookline wants to merge 1 commit intodoitintl:masterfrom
Open
Fix GCP assignment failure for STANDARD tier IP addresses#170javibookline wants to merge 1 commit intodoitintl:masterfrom
javibookline wants to merge 1 commit intodoitintl:masterfrom
Conversation
Set NetworkTier on IPv4 access configs using the addressNetworkTierOrDefault helper, matching the existing IPv6 behavior. Previously, NetworkTier was only set for IPv6 addresses, causing IPv4 STANDARD tier addresses to fail with a network tier mismatch error. Closes doitintl#155 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
javibookline
force-pushed
the
fix/standard-network-tier-ipv4
branch
from
7857856 to
cc81395
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NetworkTieron IPv4 access configs when the address uses a non-default tier (e.g. STANDARD), matching the existing IPv6 behaviorNetworkTierwas only set for IPv6 addresses increateAccessConfig(), causing IPv4 STANDARD tier addresses to fail with:External IP address has a different network tier STANDARD from the network tier in instance access config PREMIUMCloses #155
Test plan
go test ./...)