build: Use a different SONAME for the glfw WSI#3324
Closed
smcv wants to merge 1 commit into
Closed
Conversation
Selecting the GLFW WSI gives DXVK an incompatible ABI: for example, CreateDevice takes a `SDL_Window *` parameter in the default SDL WSI, but takes a `GLFWwindow *` instead in the GLFW WSI. This means it should get a different name, so that binaries expecting one WSI don't unexpectedly load the other. Resolves: doitsujin#3321 Signed-off-by: Simon McVittie <smcv@collabora.com>
This was referenced Mar 31, 2023
Contributor
|
This will be a good complement to #3365 |
Contributor
|
This got obsoleted by #3738 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selecting the GLFW WSI gives DXVK an incompatible ABI: for example, CreateDevice takes a
SDL_Window *parameter in the default SDL WSI, but takes aGLFWwindow *instead in the GLFW WSI. This means it should get a different name, so that binaries expecting one WSI don't unexpectedly load the other.Resolves: #3321