Simplify D3D9 fixed-function lighting#5720
Merged
Merged
Conversation
There was a bug somewhere in the state block code since it would lose information about enabled and disabled lights somehow.
No reason to have two when the only thing one of them does is set the other.
Div-by-zero fix in constant folding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were multiple bugs here, one with tracking enabled lights which wasn't really working properly if the app set >8 lights, and one where state blocks wouldn't disable lights.
This fixes lighting issues in Sang-Froid: Tales of Werewolves.
Also cleans up the lighting-related shader code for good measure, because dear god that was hard to disect in renderdoc.