Add tests for util/file
#21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
devpaul
suggested changes
May 9, 2017
Member
devpaul
left a comment
devpaul
left a comment
There was a problem hiding this comment.
Overall looks good. Just needs a little rewording cleanup
tests/unit/src/util/file.ts
Outdated
| }, | ||
|
|
||
| makeTempDirectory: { | ||
| 'base directory should be created if it does not exist'() { |
Member
There was a problem hiding this comment.
For consistency I recommend labeling tests as "unit under test", "condition", "result"
Can we rename these tests to follow this convention?
e.g. "base directory does not exist; directory is created"
I know it can seem a bit odd to write but the consistency reads better and it's easier to compose conditions if multiple suites are used
tests/unit/src/util/file.ts
Outdated
| mkdtempSync: mkdtempSyncStub | ||
| }, | ||
| 'mkdirp': { | ||
| sync: syncStub |
Member
There was a problem hiding this comment.
let's rename this mkdirpSyncStub so it's easier to understand what this stub does
jacobroufa
force-pushed
the
tests_util_file
branch
from
3c9024e to
d270ef3
Compare
devpaul
approved these changes
May 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.