Skip to content

Conversation

@gsexton
Copy link
Contributor

@gsexton gsexton commented Apr 26, 2018

No description provided.

@jsf-clabot
Copy link

jsf-clabot commented Apr 26, 2018

CLA assistant check
All committers have signed the CLA.

@gsexton
Copy link
Contributor Author

gsexton commented Apr 26, 2018

Dylan, can you do anything to fix the CLA Not signed. I'm at my wit's end on it. I've fixed my back-end so it won't happen again. If you could fix it or tell me how to fix it so the pull request will go through, that would be awesome.

@dylans
Copy link
Member

dylans commented Apr 26, 2018

@gsexton the clabot must have resolved itself since your last message, as this is showing approved/signed now. Will review this today.

@dylans
Copy link
Member

dylans commented Apr 26, 2018

I was reminded that this change was intentional ( see https://github.com/dojo/util/pull/63/files )... it seems like we probably need to branch by Java version given some of the changes to Java.

@pottedmeat pottedmeat self-requested a review April 26, 2018 13:21
@dylans dylans added this to the 1.15 milestone Aug 9, 2018
@dylans dylans modified the milestones: 1.15, 1.16 Feb 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants