Hide 'See Results' button when jam results are locked - #87
Merged
Conversation
When voting is submitted, show 'Back to Jams' instead of 'See Results' if the jam hasn't reached the confidence threshold for unlocking results. The decision is computed on the client using voteCount / (entryCount * CONFIDENCE_N) >= 1. Changes: - Backend: Add getComparisonCountForJam() query and include entryCount/voteCount in POST session response - Hook: Expose resultsUnlocked boolean from useJudging - Judge page: Conditionally render button destination based on results lock status Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When judges submit votes, the session-end screen now shows 'Back to Jams' instead of 'See Results' if the jam hasn't reached the confidence threshold to unlock results.
The unlock threshold is computed as:
voteCount / (entryCount * CONFIDENCE_N) >= 1, matching the client's results-locking logic.Changes:
getComparisonCountForJam()query and includeentryCount/voteCountin POST session responseresultsUnlockedboolean fromuseJudging