Skip to content

Fix Dojo metric counting in enrichment spec #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kronosapiens merged 1 commit into from
Mar 11, 2026
Merged

Fix Dojo metric counting in enrichment spec #88

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions ENRICHMENT.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,12 @@ Allow a 1-day buffer on each side for setup and polish.
Clone the submitted repository and gather:

#### Codebase Structure
- Count Dojo models (`#[dojo::model]`), systems/contracts (`#[dojo::contract]`), and events (`#[dojo::event]`) — but **only those that are genuinely load-bearing in the production experience**.
- Apply the same diagnostic used in screening: **"if you removed this contract, would the game break?"**
- Count Dojo models, systems/contracts, and events by searching for the **literal decorator macros** in Cairo source files: `#[dojo::model]`, `#[dojo::contract]`, `#[dojo::event]`.
Only items annotated with these exact decorators count.
Do not count components, structs, or events from other frameworks (e.g. EGS `MinigameComponent`, standard Starknet `#[starknet::contract]`, OpenZeppelin components) — even if they serve a similar role.
If no Dojo decorators are found, set `dojo_models`, `dojo_systems`, and `dojo_events` to 0.
- Of those decorated items, count only the ones that are **genuinely load-bearing in the production experience**.
Apply the same diagnostic used in screening: **"if you removed this contract, would the game break?"**
Only count contracts where the answer is yes.
- Red flags that a contract is NOT load-bearing (exclude from counts):
- **Optimistic client updates** — The client modifies state locally after transactions without reading results back from-chain, meaning it doesn't depend on contract computation.
Expand Down
Loading