-
Notifications
You must be signed in to change notification settings - Fork 203
feat(ci): separate sozo releases from dojo #3381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
5c53c47
31fd613
01b6d47
a2823a1
84d5615
c83f49f
c6eeafd
f894251
b84cfa5
a727151
33566d6
7725079
bccfd9f
8051b56
ed234e4
790d821
2447820
3b5aaa9
96da6bb
7bbb18e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| scarb 2.13.1 | ||
| starknet-foundry 0.51.0 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,7 +4,7 @@ ARG SOZO_VERSION | |
| ARG TARGETARCH | ||
|
|
||
| RUN apt-get update \ | ||
| && apt-get install -y --no-install-recommends ca-certificates \ | ||
| && apt-get install -y --no-install-recommends git curl wget ca-certificates \ | ||
| && rm -rf /var/lib/apt/lists/* | ||
|
|
||
| # Archive is provided by the release workflow (linux/amd64 and linux/arm64 variants). | ||
|
|
@@ -14,4 +14,33 @@ RUN tar -xzf /tmp/sozo.tar.gz -C /usr/local/bin sozo \ | |
| && rm /tmp/sozo.tar.gz \ | ||
| && chmod +x /usr/local/bin/sozo | ||
|
|
||
| # Define the ASDF related variables. | ||
| # Note that the data dir is also invovled. | ||
| ENV ASDF_VERSION=v0.18.0 | ||
| ENV ASDF_DIR=/opt/asdf | ||
| ENV ASDF_BIN_DIR=${ASDF_DIR}/bin | ||
| ENV ASDF_DATA_DIR=${ASDF_DIR}/ | ||
|
|
||
| # Add to the PATH + ensure the ASDF_DATA_DIR is also set, | ||
| # to have next invocation of asdf working as expected. | ||
| ENV PATH="${ASDF_BIN_DIR}:${ASDF_DATA_DIR}/shims:$PATH" | ||
| ENV ASDF_DATA_DIR=${ASDF_DATA_DIR} | ||
|
|
||
| # Install ASDF from pre-built binaries github release (easiest way IMHO). | ||
| RUN wget -q https://github.com/asdf-vm/asdf/releases/download/${ASDF_VERSION}/asdf-${ASDF_VERSION}-linux-${TARGETARCH}.tar.gz -O /tmp/asdf.tar.gz && \ | ||
| mkdir -p $ASDF_BIN_DIR && \ | ||
| tar -xzf /tmp/asdf.tar.gz -C $ASDF_BIN_DIR && \ | ||
| rm /tmp/asdf.tar.gz && \ | ||
| ls -laR ${ASDF_DIR} | ||
|
|
||
| RUN chmod +x $ASDF_BIN_DIR/asdf && ls -alR $ASDF_DIR/ | ||
| RUN asdf --version | ||
|
Comment on lines
+29
to
+37
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove debug output commands for cleaner Docker builds. Lines 34, 36, and 37 are verbose/debug-only commands ( Clean up the ASDF installation step: RUN wget -q https://github.com/asdf-vm/asdf/releases/download/${ASDF_VERSION}/asdf-${ASDF_VERSION}-linux-${TARGETARCH}.tar.gz -O /tmp/asdf.tar.gz && \
mkdir -p $ASDF_BIN_DIR && \
tar -xzf /tmp/asdf.tar.gz -C $ASDF_BIN_DIR && \
rm /tmp/asdf.tar.gz && \
-ls -laR ${ASDF_DIR}
-
-RUN chmod +x $ASDF_BIN_DIR/asdf && ls -alR $ASDF_DIR/
-RUN asdf --version
+chmod +x $ASDF_BIN_DIR/asdf🤖 Prompt for AI Agents |
||
|
|
||
| COPY .tool-versions /root/.tool-versions | ||
|
|
||
| RUN asdf plugin add scarb https://github.com/software-mansion/asdf-scarb.git && \ | ||
| asdf plugin add starknet-foundry https://github.com/foundry-rs/asdf-starknet-foundry && \ | ||
| asdf install && \ | ||
| asdf reshim | ||
|
|
||
| ENTRYPOINT ["sozo"] | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohayo sensei! Remove redundant ASDF_DATA_DIR assignment and fix path double-slash.
Line 22 sets
ASDF_DATA_DIRwith a trailing slash, and line 27 re-exports it identically—this is redundant. Also, the trailing slash causes${ASDF_DATA_DIR}/shimsto expand to/opt/asdf//shims(double slash), which is cosmetically sloppy and can confuse debugging.Consolidate and clean up the ASDF environment setup:
📝 Committable suggestion
🤖 Prompt for AI Agents