feat(init): point AMD TEE registry prefill at the canonical program - #632
Merged
Conversation
The Sepolia AMD TEE registry prefill (0x06ef2e9d) pinned a superseded SP1 program (0x00ed032f) — a rollup wired through it would settle against the wrong program. Update it to the settling registry 0x06616163, which pins the production TEE-VM image's program 0x0019e70e (what saya-tee actually proves). Also add a mainnet prefill (0x04ec71ae, same program) so mainnet TEE rollups get a default too. - AMD_TEE_REGISTRY_SEPOLIA -> 0x06616163 (+ refreshed doc/source; old sepolia.json link was dead) - add AMD_TEE_REGISTRY_MAINNET (0x04ec71ae) - prompt prefills the AMD registry for Mainnet + Sepolia Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.30.
| Benchmark suite | Current: 1cf5165 | Previous: 5f81a1f | Ratio |
|---|---|---|---|
FinalityStatus/compress |
1 ns/iter (± 0) |
0 ns/iter (± 0) |
+∞ |
TypedTransactionExecutionInfo/compress |
18011 ns/iter (± 100) |
13549 ns/iter (± 53) |
1.33 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @kariy
Codec benchmark diff vs
|
| Benchmark | Baseline (ns) | Current (ns) | Δ |
|---|---|---|---|
CompiledClass(fixture)/compress |
2637825 | 2677558 | +1.51% |
CompiledClass(fixture)/decompress |
2782005 | 2810572 | +1.03% |
ExecutionCheckpoint/compress |
34 | 30 | -11.76% |
ExecutionCheckpoint/decompress |
25 | 23 | -8.00% |
PruningCheckpoint/compress |
34 | 30 | -11.76% |
PruningCheckpoint/decompress |
25 | 23 | -8.00% |
VersionedHeader/compress |
671 | 648 | -3.43% |
VersionedHeader/decompress |
886 | 825 | -6.88% |
StoredBlockBodyIndices/compress |
78 | 74 | -5.13% |
StoredBlockBodyIndices/decompress |
38 | 34 | -10.53% |
StorageEntry/compress |
158 | 142 | -10.13% |
StorageEntry/decompress |
157 | 140 | -10.83% |
ContractNonceChange/compress |
173 | 145 | -16.18% |
ContractNonceChange/decompress |
273 | 244 | -10.62% |
ContractClassChange/compress |
202 | 187 | -7.43% |
ContractClassChange/decompress |
277 | 256 | -7.58% |
ContractStorageEntry/compress |
169 | 151 | -10.65% |
ContractStorageEntry/decompress |
351 | 317 | -9.69% |
GenericContractInfo/compress |
135 | 133 | -1.48% |
GenericContractInfo/decompress |
118 | 102 | -13.56% |
Felt/compress |
94 | 80 | -14.89% |
Felt/decompress |
63 | 54 | -14.29% |
BlockHash/compress |
90 | 80 | -11.11% |
BlockHash/decompress |
63 | 54 | -14.29% |
TxHash/compress |
94 | 80 | -14.89% |
TxHash/decompress |
63 | 54 | -14.29% |
ClassHash/compress |
92 | 81 | -11.96% |
ClassHash/decompress |
62 | 53 | -14.52% |
CompiledClassHash/compress |
94 | 81 | -13.83% |
CompiledClassHash/decompress |
62 | 54 | -12.90% |
BlockNumber/compress |
51 | 46 | -9.80% |
BlockNumber/decompress |
24 | 24 | +0.00% |
TxNumber/compress |
50 | 46 | -8.00% |
TxNumber/decompress |
25 | 24 | -4.00% |
FinalityStatus/compress |
0 | 1 | +Infinity% |
FinalityStatus/decompress |
10 | 10 | +0.00% |
TypedTransactionExecutionInfo/compress |
13549 | 18011 | +32.93% |
TypedTransactionExecutionInfo/decompress |
3747 | 3643 | -2.78% |
VersionedContractClass/compress |
368 | 394 | +7.07% |
VersionedContractClass/decompress |
805 | 794 | -1.37% |
MigratedCompiledClassHash/compress |
168 | 146 | -13.10% |
MigratedCompiledClassHash/decompress |
158 | 138 | -12.66% |
ContractInfoChangeList/compress |
1409 | 1390 | -1.35% |
ContractInfoChangeList/decompress |
2249 | 2104 | -6.45% |
BlockChangeList/compress |
611 | 608 | -0.49% |
BlockChangeList/decompress |
934 | 859 | -8.03% |
ReceiptEnvelope/compress |
26972 | 28161 | +4.41% |
ReceiptEnvelope/decompress |
6505 | 6099 | -6.24% |
TrieDatabaseValue/compress |
148 | 167 | +12.84% |
TrieDatabaseValue/decompress |
264 | 212 | -19.70% |
TrieHistoryEntry/compress |
278 | 289 | +3.96% |
TrieHistoryEntry/decompress |
305 | 238 | -21.97% |
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #632 +/- ##
==========================================
- Coverage 73.32% 68.08% -5.24%
==========================================
Files 209 334 +125
Lines 23132 46716 +23584
==========================================
+ Hits 16961 31806 +14845
- Misses 6171 14910 +8739 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
katana init rollupprefills the TEE registry address when you pick a TEE proof mode. The Sepolia AMD registry constant pointed at0x06ef2e9d…, which pins a superseded SP1 program (0x00ed032f…). A rollup initialized through that prefill would settle against a registry that rejects the current proofs ("Wrong program").This updates the prefill to the canonical settling registry and adds a mainnet default.
Changes
AMD_TEE_REGISTRY_SEPOLIA0x06ef2e9d…→0x06616163a5221890df1772a504f94d02122a12ed5b4c35ef7480b19b04c73761— the Sepolia settling registry that pins the production TEE-VM image's SP1 program0x0019e70e…(whatsaya-teeproves). Refreshed the doc comment +Sourcelink (the olddeployments/sepolia.jsonlink was dead — that file was removed in katana-tee).AMD_TEE_REGISTRY_MAINNET=0x04ec71aee9b92315ec2a7368eace15fd82fd816dd74ce9d0afcfc7077cf9fe2d— the mainnet registry pinning the same0x0019e70e…program.prompt.rs: prefill the AMD registry for Mainnet + Sepolia (previously Sepolia only).Context
cartridge-gg/katana-teemade the SP1 v6.1.0 alloy14 build canonical (program0x0019e70e…), matching the production TEE-VM image. The registries that pin it are0x06616163(Sepolia) and0x04ec71ae(mainnet). Sources: katana-tee README / mainnet.json @99b4096.Testing
cargo test -p katana cli::init::tests— 26 passed. Prefill remains editable; the--teeCLI-flag path (explicit--tee-registry-address) is unchanged.🤖 Generated with Claude Code