chore(ops): pin rust toolchain to 1.89 to match the rest of saya - #69
Merged
Conversation
bin/ops was the only crate pinned to 1.91; everything else is on 1.87 or 1.89. Release workflow's `Install target` step only pre-installs the cross-compile target for 1.87 and 1.89, so 1.91's absence produced `error[E0463]: can't find crate for core` on every release matrix job and blocked v0.3.2. Drop to 1.89. Clean release build succeeds locally; no MSRV issues from dojo-utils, starknet-rs, or any transitive dep. Sidesteps the workflow fix in #68 (which would also work but adds maintenance surface when toolchains drift again). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2 tasks
kariy
added a commit
that referenced
this pull request
Apr 22, 2026
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
`bin/ops` was the only crate on Rust 1.91; everything else is 1.87 or 1.89. Drops `bin/ops/rust-toolchain.toml` from `channel = "1.91"` → `"1.89"`. Compiles clean at 1.89.
Why
The release workflow pre-installs cross-compile targets for toolchains 1.87 and 1.89. 1.91 was never added. When the release build ran `cargo build --target ` inside `bin/ops`, rustup auto-downloaded 1.91 but without the target stdlib pre-installed — producing `error[E0463]: can't find crate for core` on every matrix job and blocking v0.3.2.
Two ways to fix:
The second is cheaper: one fewer pinned toolchain to worry about, no new CI surface, and the 1.91 pin was never justified by any MSRV need (all deps build clean at 1.89).
Test plan
Relation to #68
Supersedes #68. If this merges, #68 can close without landing — the workflow stays minimal.
🤖 Generated with Claude Code