Skip to content

Conversation

@c4lliope
Copy link

@c4lliope c4lliope commented Jul 11, 2022

A second approach, replacing #270 .

In SELinux machines, users can add --env PERMISSIONS_CALLS='--privileged'
inside their docker container run dokku/dokku call,
and the flag will be applied during these letsencrypt commands.

@c4lliope
Copy link
Author

  • change PERMISSIONS_CALLS -> PERMISSION_CALL. Simpler.

@josegonzalez
Copy link
Member

Mind rebasing this onto master? I can take a look at it then :)

@c4lliope
Copy link
Author

c4lliope commented Aug 8, 2022

Yep, done.

@yorch
Copy link

yorch commented Oct 5, 2022

Experiencing this permission denied error as well when running Dokku inside Docker and trying to enable the plugin on an app

@josegonzalez
Copy link
Member

@c4lliope what happens if PERMISSIONS_CALLS isn't set? Does this still work as expected?

@abedmaatalla
Copy link

@c4lliope Thanks for your hard work. can you rebase please ?

@bitwombat
Copy link

@c4lliope Thanks for your hard work. can you rebase please ?

Three years later?!

@c4lliope
Copy link
Author

Oh. Uh. I gotta say, I'm looking at this changeset and it all looks foreign to me after three years. I had no idea i dug so much into dokku core. I think the program is solid, only i haven't touched it in... 3 years, as the wombat says.

These days im more or less hoping to replace dokku using nix, containers or no. I also like the look of dockge for docker-compose deployments.

I could rebase and keep the spelling the same, but there's no chance that i can test this for real using selinux. Damn this is a curveball. If someone else is able, please hop in. Otherwise i may be spending a few days i don't have the luxury to spend.

I'd do it though because i wouldn't have been homelabbing at all without dokku. You helped me escape heroku 5 years ago and this is the least i could do.

Is anyone up for pair programming by chance? We could organize in the discord to push this along.

@josegonzalez
Copy link
Member

Honestly I just needed an answer to my original question and I probably would have merged this years ago.

I'll likely have time to pick this up soon, I'm aware that the docker-based installation of the letsencrypt plugin doesn't quite work due to how the plugin passes around arguments and files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants