Skip to content

Ads Pagination to the comments section #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ghost wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Ads Pagination to the comments section #280

Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
c23f387
Ads Pagination to the comments section
Dec 2, 2018
1cf237f
Update action.php
Dec 2, 2018
5296aba
fixed pag=1 error and improved the layout
Dec 2, 2018
de9e755
Update action.php
Dec 2, 2018
e1ad50a
This fixes the php 7.2 php count error when there is no content
Dec 3, 2018
b88629f
Update action.php
Dec 3, 2018
bfe5a69
Update action.php
Dec 3, 2018
7ee6825
Update action.php
Dec 3, 2018
1571aab
Removed content count because of php 7.2 bug add page_amount
Dec 3, 2018
04352ee
I think this finally fixed the php 7.2 count error.
Dec 3, 2018
631772a
Update action.php
Dec 3, 2018
ec09531
Removed comment_count variable
Dec 3, 2018
2cd6c43
forgot to remove a comment
Dec 3, 2018
34d5862
updates code a little bit.
Dec 15, 2018
b15e087
Update action.php
Dec 15, 2018
d20da5a
Update action.php
Dec 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 50 additions & 1 deletion action.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,56 @@ protected function _show($reply = null, $edit = null) {
ptln('</a></h2>', 2);
ptln('<div class="level2 hfeed">', 2);
}


// How many items to list per page
$nItemsPerPage = 50;
// How many pages will there be
$max_pages = ceil($cnt / $nItemsPerPage);
// What page are we currently on?
$page = min($max_pages, filter_input(INPUT_GET, 'page', FILTER_VALIDATE_INT, array(
'options' => array(
'default' => 1,
'min_range' => 1,
),
)));
// now display the comments
if (isset($data['comments'])) {
if (!$this->getConf('usethreading')) {
$data['comments'] = $this->_flattenThreads($data['comments']);
uasort($data['comments'], '_sortCallback');
}
if($this->getConf('newestfirst')) {
$data['comments'] = array_reverse($data['comments']);
}
foreach (array_slice ($data['comments'], $nItemsPerPage*($page-1), $nItemsPerPage) as $key => $value) {
if ($key == $edit) $this->_form($value['raw'], 'save', $edit); // edit form
else $this->_print($key, $data, '', $reply);
}
}
// Previous Button
$previous = '';
if($_GET['page'] > 1)
$previous .= '<a href="?&page='.($_GET['page']-1).'">';
$previous .= 'Previous';
$previous .= '</a>';
// Next Button
$next = '';
if($_GET['page'] < $max_pages)
if($_GET['page'] == 0)//the page=1 url doesn't show up at first so need to count from 2 at the beginning
$next .= '<a href="?&page='. ($_GET['page']+2).'">';
else
$next .= '<a href="?&page='. ($_GET['page']+1).'">';
$next .= ' Next';
$next .= '</a>';
// Comment Amount
$comment_amount = '';
$comment_amount .= '<span> ' .$cnt.' Comments</span>';
// Page Amount
$page_amount = '';
$page_amount .= '<span> ' .$max_pages.' Pages</span>';
// Call the data
echo '<div id="media_pagination">'.$previous, $next, $page_amount.'</div>'.NL;

// now display the comments
if (isset($data['comments'])) {
if (!$this->getConf('usethreading')) {
Expand Down