Skip to content

feat: Adds retry mechanism on failure and debugging support #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 3, 2025
Merged

feat: Adds retry mechanism on failure and debugging support #2

merged 1 commit into from
Jan 3, 2025

Conversation

@dol
Copy link
Owner

@dol dol commented Jan 3, 2025

  • Added max_attempts and failed_attempts_backoff_timeout fields to schema
  • Updated plugin.properties to include EmmyLua Debugger version
  • Introduced launch configuration for EmmyLua Debugger in VSCode
  • Enhanced changelog with new features and improvements
  • Modified Dockerfile to install EmmyLua Debugger
  • Added custom Busted script for improved testing with EmmyLua Debugger

@github-actions
Copy link

github-actions bot commented Jan 3, 2025 •
edited
Loading

Luacheck Report

10 tests  ±0   10 ✅ ±0   0s ⏱️ ±0s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 24e3112. ± Comparison against base commit c9245b8.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Jan 3, 2025

Test Results

22 tests  +7   22 ✅ +7   0s ⏱️ ±0s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 4ac39d6. ± Comparison against base commit c9245b8.

This pull request removes 10 and adds 17 tests. Note that renamed tests count towards both. 
/kong-plugin/spec/kong-authz-openfga/01-schema_spec.lua:71 ‑ kong-authz-openfga: (#schema) does not accepts missing required fields
/kong-plugin/spec/kong-authz-openfga/02-unit_spec.lua:131 ‑ kong-authz-openfga: (unit) [#basic] invalid mock response
/kong-plugin/spec/kong-authz-openfga/02-unit_spec.lua:131 ‑ kong-authz-openfga: (unit) [#basic_contextual] invalid mock response
/kong-plugin/spec/kong-authz-openfga/02-unit_spec.lua:131 ‑ kong-authz-openfga: (unit) [#sandbox] invalid mock response
/kong-plugin/spec/kong-authz-openfga/02-unit_spec.lua:138 ‑ kong-authz-openfga: (unit) [#basic] allow
/kong-plugin/spec/kong-authz-openfga/02-unit_spec.lua:138 ‑ kong-authz-openfga: (unit) [#basic_contextual] allow
/kong-plugin/spec/kong-authz-openfga/02-unit_spec.lua:138 ‑ kong-authz-openfga: (unit) [#sandbox] allow
/kong-plugin/spec/kong-authz-openfga/02-unit_spec.lua:155 ‑ kong-authz-openfga: (unit) [#basic] deny
/kong-plugin/spec/kong-authz-openfga/02-unit_spec.lua:155 ‑ kong-authz-openfga: (unit) [#basic_contextual] deny
/kong-plugin/spec/kong-authz-openfga/02-unit_spec.lua:155 ‑ kong-authz-openfga: (unit) [#sandbox] deny

/kong-plugin/spec/kong-authz-openfga/01-schema_spec.lua:73 ‑ kong-authz-openfga: (#schema) does not accepts missing required fields
/kong-plugin/spec/kong-authz-openfga/02-unit_spec.lua:190 ‑ kong-authz-openfga: (unit) [#basic] invalid mock response
/kong-plugin/spec/kong-authz-openfga/02-unit_spec.lua:190 ‑ kong-authz-openfga: (unit) [#basic_contextual] invalid mock response
/kong-plugin/spec/kong-authz-openfga/02-unit_spec.lua:190 ‑ kong-authz-openfga: (unit) [#basic_multiple_attempts] invalid mock response
/kong-plugin/spec/kong-authz-openfga/02-unit_spec.lua:190 ‑ kong-authz-openfga: (unit) [#sandbox] invalid mock response
/kong-plugin/spec/kong-authz-openfga/02-unit_spec.lua:197 ‑ kong-authz-openfga: (unit) [#basic] allow
/kong-plugin/spec/kong-authz-openfga/02-unit_spec.lua:197 ‑ kong-authz-openfga: (unit) [#basic_contextual] allow
/kong-plugin/spec/kong-authz-openfga/02-unit_spec.lua:197 ‑ kong-authz-openfga: (unit) [#basic_multiple_attempts] allow
/kong-plugin/spec/kong-authz-openfga/02-unit_spec.lua:197 ‑ kong-authz-openfga: (unit) [#sandbox] allow
/kong-plugin/spec/kong-authz-openfga/02-unit_spec.lua:215 ‑ kong-authz-openfga: (unit) [#basic] deny
…

@github-actions
Copy link

github-actions bot commented Jan 3, 2025 •
edited
Loading

LCOV of commit 24e3112 during Test #35

Summary coverage rate:
  lines......: 65.7% (92 of 140 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate:
                                             |Lines       |Functions  |Branches    
  Filename                                   |Rate     Num|Rate    Num|Rate     Num
  =================================================================================
  kong/plugins/kong-authz-openfga/access.lua | 0.0%     19|    -     0|    -      0
  kong/plugins/kong-authz-openfga/schema.lua | 0.0%     67|    -     0|    -      0

@dol
feat: Adds retry mechanism on failure and debugging support
24e3112 
- Added max_attempts and failed_attempts_backoff_timeout fields to schema
- Updated plugin.properties to include EmmyLua Debugger version
- Introduced launch configuration for EmmyLua Debugger in VSCode
- Enhanced changelog with new features and improvements
- Modified Dockerfile to install EmmyLua Debugger
- Added custom Busted script for improved testing with EmmyLua Debugger
@dol dol force-pushed the feature/add-retry branch from 4ac39d6 to 24e3112 Compare January 3, 2025 17:58
@dol dol merged commit ec4a44c into main Jan 3, 2025
7 checks passed
@dol dol deleted the feature/add-retry branch February 13, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dol