DolphinQt: Fix unresponsive hotkeys when clicking overlay during a framestep #13448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the following bug: * Have a moveable ImGui overlay enabled, such as the Statistics window. * Pause the game. * Click and hold on the overlay's title bar as if you were going to move it. Because the screen isn't updating while the game is paused, you won't be able to actually move the overlay. * Press the Frame Advance hotkey several times until it stops responding. At this point emulation hotkeys are no longer responsive. This can be resolved by selecting Play from the toolbar or menu, or selecting Frame Advance from the menu a couple times, but it's annoying and not obvious what's gone wrong or how to fix it. Why the bug is happening: * Doing a framestep while clicking on the overlay title bar causes ImGui to set IO.WantCaptureKeyboard to true, indicating that ImGui is requesting Dolphin ignore any keyboard events while the overlay is being interacted with. * Dolphin complies with this request, causing Host_UIBlocksControllerState to return true and thus setting the input gate to ignore input. * IO.WantCaptureKeyboard is only updated when ImGui::NewFrame() is called, which only happens at the end of each present. It thus remains true indefinitely since the game paused after the last framestep, and so Dolphin ignores any hotkeys such as the framestep or play keys. The fix: Ignore IO.WantCaptureKeyboard when the game is paused. ImGui can't meaningfully capture input anyway when the game is paused, so this shouldn't cause any problems elsewhere. Once async presentation is implemented we'll want to revert this change, both because it'll become unnecessary and because ImGui will be able to do stuff while paused and so suppressing emulation hotkeys will actually be useful.
|
FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:
automated-fifoci-reporter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the following bug:
At this point emulation hotkeys are no longer responsive. This can be resolved by selecting Play from the toolbar or menu, or selecting Frame Advance from the menu a couple times, but it's annoying and not obvious what's gone wrong or how to fix it.
Why the bug is happening:
The fix:
Ignore IO.WantCaptureKeyboard when the game is paused. ImGui can't meaningfully capture input anyway when the game is paused, so this shouldn't cause any problems elsewhere.
Once async presentation is implemented we'll want to revert this change, both because it'll become unnecessary and because ImGui will be able to do stuff while paused and so suppressing emulation hotkeys will actually be useful.