Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add numeric label support to assembler #13451

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add numeric label support to assembler #13451

wants to merge 1 commit into from

Conversation

vyuuui
Copy link
Contributor

@vyuuui vyuuui commented Mar 24, 2025

Frequently used feature in most common assemblers I'd forgotten to add.

@dolphin-ci
Copy link

dolphin-ci bot commented Mar 25, 2025

FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:

  • sw3-dt on mvk-osx-m1: diff
  • f-zero-rain on mtl-osx-m1: diff

automated-fifoci-reporter

sepalani
sepalani approved these changes Mar 27, 2025
View reviewed changes
Copy link
Contributor

@sepalani sepalani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code seems fine. Tested on Windows with the assembler widget.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sepalani sepalani sepalani approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vyuuui @sepalani