Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use std::views::values and std::views::keys functions #13472

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use std::views::values and std::views::keys functions #13472

wants to merge 1 commit into from
+19 −18

Conversation

tygyh
Copy link
Contributor

@tygyh tygyh commented Mar 29, 2025

No description provided.

jordan-woyak
jordan-woyak reviewed Mar 30, 2025
View reviewed changes
Copy link
Member

@jordan-woyak jordan-woyak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message could be a bit better, mentioning NetPlayServer and std::views::keys.

@tygyh tygyh force-pushed the Use-values-function branch from ef26a32 to c847fc9 Compare March 30, 2025 08:11
@tygyh tygyh force-pushed the Use-values-function branch from c847fc9 to a786de9 Compare March 30, 2025 14:37
@tygyh tygyh changed the title Use std::views::values function Use std::views::values and std::views::keys functions Mar 30, 2025
@tygyh tygyh requested review from sepalani and jordan-woyak March 30, 2025 15:21
jordan-woyak
jordan-woyak requested changes Mar 30, 2025
View reviewed changes
Copy link
Member

@jordan-woyak jordan-woyak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a typo in the commit message, Ues vs Use.

@tygyh tygyh force-pushed the Use-values-function branch from a786de9 to 94bb417 Compare March 30, 2025 20:04
@tygyh tygyh requested a review from jordan-woyak March 30, 2025 20:05
sepalani
sepalani approved these changes Mar 31, 2025
View reviewed changes
Copy link
Contributor

@sepalani sepalani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, untested.

@tygyh tygyh force-pushed the Use-values-function branch from 94bb417 to ebc9c84 Compare April 2, 2025 18:06
@dolphin-ci
Copy link

dolphin-ci bot commented Apr 3, 2025

FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:

automated-fifoci-reporter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BhaaLseN BhaaLseN BhaaLseN approved these changes

@jordan-woyak jordan-woyak jordan-woyak approved these changes

@sepalani sepalani sepalani approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tygyh @BhaaLseN @jordan-woyak @sepalani