-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMakeLists: Bump minimum macOS to 11.0 #13477
base: master
Are you sure you want to change the base?
Conversation
…ent target flags I can't see any situation in the foreseeable future where we need to target different macOS versions for each architecture.
The minimum macOS (and minimum iOS on my personal fork) are enough to allow MSL 2.3 usage without availability checks.
My personal fork requires minimum iOS 14, so this is not required.
FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system: automated-fifoci-reporter |
What benefits does bumping the spec bring in this case? Generally 2% is a little more than I'd like for a cutoff. However, that's 2% of our macOS users which make up about a percent of our userbase, so in total this affects a very small number of our total users. So I'm not opposed to this, but I am curious about what we gain from this move. Also this finally cuts off my 2012 macbook pro from the latest Dolphin builds. At least, unless I get creative. |
I was pushing for a macOS spec bump for a It would also allow for a Qt version bump. Also, even macOS 12 is EOL. Apple doesn't support macOS 10, why should we. :P |
It also looks like Dolphin is currently broken on 10.15 due to PR #13269: https://bugs.dolphin-emu.org/issues/13743. I've unfortunately had to leave it broken due to my lack of a testing environment. |
If it's broken anyway, perhaps we should merge this and if a work-around is found we can always revert it? |
Bumps the minimum macOS version to 11.0 Big Sur. I've also gone ahead and removed some checks for macOS 10.15 which were missed when the last version bump happened.
Approximately ~2.6% of our macOS users within the past 30 days (and have analytics enabled) are running a version of macOS 10.15 Catalina.
Analytics data