Update XFMemory.h to Dolphin's version and use its constants#50
Open
Pokechu22 wants to merge 2 commits intodolphin-emu:masterfrom
Open
Update XFMemory.h to Dolphin's version and use its constants#50Pokechu22 wants to merge 2 commits intodolphin-emu:masterfrom
Pokechu22 wants to merge 2 commits intodolphin-emu:masterfrom
Conversation
Note that I've removed the XFMemory struct itself, as well as the load/preprocess functions.
Pokechu22
force-pushed
the
update-xfmemory
branch
from
abcde44 to
42a881f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is refactoring to make future work on a lighting test easier. (I haven't rerun tests with this change yet, but I have confirmed that everything builds.)