implement dolt_branch_status()
#9122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@coffeegoddd DOLT
|
Contributor
macneale4
requested changes
Apr 17, 2025
go/libraries/doltcore/sqle/dtablefunctions/dolt_diverge_table_function.go
Show resolved
Hide resolved
Contributor
Contributor
Contributor
Contributor
|
@coffeegoddd DOLT
|
macneale4
requested changes
Apr 21, 2025
Contributor
macneale4
left a comment
macneale4
left a comment
There was a problem hiding this comment.
Looking good. I'm not sure why the test I pushed fails, but it must have something to do with the commit walking.
go/libraries/doltcore/sqle/dtablefunctions/dolt_branch_status_table_function.go
Outdated
Show resolved
Hide resolved
go/libraries/doltcore/sqle/dtablefunctions/dolt_branch_status_table_function.go
Outdated
Show resolved
Hide resolved
go/libraries/doltcore/sqle/dtablefunctions/dolt_branch_status_table_function.go
Show resolved
Hide resolved
Contributor
|
@macneale4 DOLT
|
Contributor
Contributor
|
@coffeegoddd DOLT
|
Contributor
Contributor
macneale4
requested changes
Jun 2, 2025
Contributor
macneale4
left a comment
macneale4
left a comment
There was a problem hiding this comment.
One thing I think you can simplify.
go/libraries/doltcore/sqle/dtablefunctions/dolt_branch_status_table_function.go
Outdated
Show resolved
Hide resolved
Contributor
macneale4
approved these changes
Jun 2, 2025
Contributor
macneale4
left a comment
macneale4
left a comment
There was a problem hiding this comment.
~.
Ya...___|__..aab . .
Y88a Y88o Y88a ( )
Y88b Y88b Y88b `.oo'
:888 :888 :888 ( (`-'
.---. d88P d88P d88P `.`.
/ .-._) d8P'"""|"""'-Y8P `.`.
( (`._) .-. .-. |.-. .-. .-. ) )
\ `---( O )( O )( O )( O )( O )-' /
`. `-' `-' `-' `-' `-' .' CJ
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
dolt_branch_status(<base_branch>, <feature_branch1>, <feature_branch2>, ...).The function compares
base_branchagainst each of the feature branches and outputs a table that lists how many commits ahead and behind base branch.Additionally, this PR contains some cleanup/refactoring.
addresses: #9090